Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Implement multiple option for select field #3572
base: main
Are you sure you want to change the base?
feature: Implement multiple option for select field #3572
Changes from 10 commits
e599393
77d8daf
fdaf270
c833b6b
4931ab8
e91098e
4c9410b
76185b2
24c59f3
bae862e
67a12b0
3446019
f688e59
f8a4a3e
557e303
9f26661
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhephyn let's start by fixing the schema, the
AddSizesToProducts
migration is adding thesizes
array column to theproducts
table however the schema is also changing thestage
column to array on theprojects
table.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm directly committing this change to speed up the process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay no problem. Im not directly in contact with my computer at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Paul-Bob . Though I didn't quite understand what you referenced, you specified a migration named AddSizesToProducts, yet according to the suggested change, it's like you're changing the stage column to a non array column, and the stage column is part of the projects table not the products table. Could you kindly clarify if this is the case?
Check failure on line 236 in spec/features/avo/select_field_spec.rb
GitHub Actions / lint / runner / standardrb
Check failure on line 237 in spec/features/avo/select_field_spec.rb
GitHub Actions / lint / runner / standardrb
Check failure on line 237 in spec/features/avo/select_field_spec.rb
GitHub Actions / lint / runner / standardrb
Check failure on line 238 in spec/features/avo/select_field_spec.rb
GitHub Actions / lint / runner / standardrb
Check failure on line 238 in spec/features/avo/select_field_spec.rb
GitHub Actions / lint / runner / standardrb
Check failure on line 247 in spec/features/avo/select_field_spec.rb
GitHub Actions / lint / runner / standardrb
Check failure on line 247 in spec/features/avo/select_field_spec.rb
GitHub Actions / lint / runner / standardrb
Check failure on line 248 in spec/features/avo/select_field_spec.rb
GitHub Actions / lint / runner / standardrb
Check failure on line 248 in spec/features/avo/select_field_spec.rb
GitHub Actions / lint / runner / standardrb