Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explicit authorization #3453

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix: explicit authorization #3453

merged 3 commits into from
Nov 22, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Nov 21, 2024 •
edited
Loading

Description

Fixes #3447

Now explicit_authorization makes no impact when authorization_client is nil

Tests here: https://github.com/avo-hq/avo-pro/pull/97

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Nov 21, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 21, 2024 •
edited
Loading

Code Climate has analyzed commit 2ef9180 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit f61dd2b into main Nov 22, 2024
20 of 21 checks passed
@Paul-Bob Paul-Bob deleted the fix/explicit_authorization branch November 22, 2024 20:22
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't take explicit_authorization into consideration when authorization_client = nil
1 participant
@Paul-Bob