Fix for Android 13 in TypeText.kt so that tests with text input can work #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext.kt so it could be found via reflection. This change is required for Android 13.
dsvoronin
reviewed
Jan 23, 2023
| @@ -75,7 +75,7 @@ internal class TypeText(private val stringToBeTyped: String) : ViewAction { | |||
| ApplicationProvider.getApplicationContext<Application>() | |||
| .getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager | |||
| ) | |||
| .getFieldByReflectionWithAnyField("mIInputContext") | |||
| .getFieldByReflectionWithAnyField("mFallbackInputConnection") | |||
There was a problem hiding this comment.
Hey, it should be under "SDK check if", right?
There was a problem hiding this comment.
@Chog0 What do you think could you make changes with SDK check?
There was a problem hiding this comment.
Sure, will do that and ask you for review when it's ready.
Thanks for pointing this out, guys!
There was a problem hiding this comment.
I will merge and create a release
Chog0
requested review from
dsvoronin and
sboishtyan
and removed request for
dsvoronin and
sboishtyan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix eliminates this issue #1425