Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental dark mode #606

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Experimental dark mode #606

wants to merge 7 commits into from

Conversation

jenspav
Copy link
Collaborator

@jenspav jenspav commented Sep 11, 2024

Also switches to structurizr as the default exporter.

Supersedes #528

jenspav and others added 2 commits September 11, 2024 09:56
Co-authored-by: LunarN0va <[email protected]>
@jenspav jenspav mentioned this pull request Sep 11, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated
| `generatr.site.externalTag` | Software systems containing this tag will be considered external | | |
| `generatr.site.nestGroups` | Will show software systems in the left side navigator in collapsable groups | `false` | `true` |
| `generatr.site.cdn` | Specifies the CDN base location for fetching NPM packages for browser runtime dependencies. Defaults to jsDelivr, but can be changed to e.g. an on-premise location. | `https://cdn.jsdelivr.net/npm` | `https://cdn.my-company/npm` |
| `generatr.site.darkMode` | Experimental: will show a dark mode menu item to switch between light and dark mode on the website. If turned off, the site will be shown in light mode and this menu item will not be shown. | `false` | `true` |
Copy link
Collaborator Author

@jenspav jenspav Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make this a three-state option: forced light theme, forced dark theme, auto (based on browser or user choice)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add notes that colors for site and diagrams should be adjusted to any of those choices.

@jenspav jenspav marked this pull request as ready for review September 11, 2024 15:11
@jenspav
Copy link
Collaborator Author

jenspav commented Sep 11, 2024

Ready to play. Note that the gray background in the light theme is gone. I think this fits, but taste may differ.

Also move static styling to styles.css.
Plays slightly better with the dark theme,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant