Nested Groups in sideNav

[qtzar]

This PR adds a new way to generate the side nav that accounts for nested groups in the structurizer DSL as the softwareSystem level.

I have tested this with a workspace.dsl that contains nested groups as well as the example workspace.dsl that does not contain any groups.

[dirkgroot]

@qtzar Thanks for your PR. I'm not sure if I like this change, for a couple of reasons:

• User experience:
  • It add visual clutter to the menu, because of the dashed lines and + and - symbols.
  • The style of the menu is not consistent with the style of the rest of the menu. It's more crammed, and indentation is different.
  • All groups are collapsed by default, which (especially for smaller models) isn't really necessary, I think.
  • Navigation through the available systems via the menu now requires more mouse clicks.
• I'm not sure if this is the best way to visualize groups in the site. I think it's a nice addition, but I think I'd prefer a somewhat more minimalistic approach, but I'm not sure what that should look like. Any ideas (CC @jp7677)?

[jp7677]

I'm torn about introducing a tree view for the software systems. Like dirkgroot I'm also found of the simple flat list of all software systems. Considering that groups allow a lot of flexibility (multiple groups, nesting) and can be used for a lot of different meanings, I'm in doubt that we can find a presentation that fits everyone.

My advise for how to present (certain) groups more prominently would be to use global documentation (which appear in the menu, like System Landscape in the example) and then use embedded views with exactly the groups and systems plus context you need for a certain use case.

[pietermees]

@qtzar we'd love to use this functionality, I was wondering if this was still something you were pursuing or whether it's stale?

[qtzar]

I would LOVE to have this functionality merged in also. I probably have to rebuild it a little as the main branch has moved on quite a bit and I'd make sure that it can be enabled/disabled as wanted.

@dirkgroot @jp7677 What do you think? Could this feature be considered again?

[qtzar]

I rebuilt the functionality on top of the most current main branch and then forced a commit to my branch to eliminate all previous commits.

[qtzar]

Here is an updated screenshot ( ignore the blacked out bit to hide company name ). As mentioned in one of the outdated comments we have 400+ systems and the simple flat list is just unusable. We do have sets of landscape views based on certain major groups and show sub groups within those landscape docs but it doesn't negate that fact that 400+ systems means a really long scroll on the page.

[jp7677]

Sorry for the late review, it has been rather busy :(.

This PR is shaping up nicely and since it is an opt-in, I'm fine to get this in. Could you please look at my comments/suggestions. I haven't tested them, so likely bugs are included ;)

Could you please also add a few tests that validate the construction of the MenuNodes?

[jp7677]

Just some whitespace nits left...

[qtzar]

@jp7677 Thanks for taking the time to help with this PR.

[jp7677]

2 empty lines left...

[jp7677]

@qtzar All good, but unfortunately conflicts, can you please bring this branch in line with main?

[qtzar]

@jp7677 I'm not showing my branch being behind main.

[jp7677]

@jp7677 I'm not showing my branch being behind main.

Sry, my bad, my merge button was on "rebase", that isn't possible due to conflicts (due to the merge commits in this branch) . that said other merge modes are indeed fine.