Use MergedEvent to improve the merge commit detection #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
✅ FlexReview StatusOwner: |
tulioz
approved these changes
Jan 2, 2025
draftcode
force-pushed
the
better_merge_detection
branch
from
7259cf1 to
66bb6c7
Compare
Even though PR is in "MERGED" state, the mergeCommit field can be empty in the GitHub API response. Use the MergedEvent to get the merge commit hash to complement the detection.
draftcode
force-pushed
the
better_merge_detection
branch
from
66bb6c7 to
ac1fde9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though PR is in "MERGED" state, the mergeCommit field can be empty
in the GitHub API response. Use the MergedEvent to get the merge commit
hash to complement the detection.