Update av stack submit to open PRs in browser after entire stack is submitted #268
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
FlexReview SummaryThere is not enough data in the repository for FlexReview to determine suggested reviewers. Detailed BreakdownAuthor’s expertise score for the modified files:
See full breakdown of the reviewers on the Aviator webapp. |
cmd/av/stack_submit.go
Outdated
| }, | ||
| ) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if result.Created { | ||
| lastCreatedPullRequest = result.Branch.PullRequest |
There was a problem hiding this comment.
An alternative behavior would be to wait until all the PRs are created first, and then bulk-open all new windows at once.
With stack visualizations in #264, IMO that's unnecessary since the last created PR will have links to all the other stacks.
However, if it's off perhaps it would still make sense to open a bunch of new windows, or alternatively just open the repo to the PR list, e.g., https://github.com/aviator-co/av/pulls.
Thoughts?
There was a problem hiding this comment.
@draftcode could you let me know what you think?
There was a problem hiding this comment.
I feel like if we open PR pages (which is default), then it's better to open all (i.e. changing this to bulk open). I usually do not use av stack submit (usually use `av pr create), but I want to check the newly created PRs for the last check.
There was a problem hiding this comment.
Or make this configurable.
There was a problem hiding this comment.
Alright, for now I updated to just bulk open them all at once at the end. That feels less disruptive than opening one by one and requiring you to keep switching between browser and terminal.
oleg-codaio
force-pushed
the
osv-last-stack-only
branch
from
6834edc to
74837be
Compare
|
/aviator refresh |
Aviator status snapshotThis pull request is currently open (not queued). How to mergeTo merge this PR, comment You can also comment |
2 similar comments
Aviator status snapshotThis pull request is currently open (not queued). How to mergeTo merge this PR, comment You can also comment |
Aviator status snapshotThis pull request is currently open (not queued). How to mergeTo merge this PR, comment You can also comment |
oleg-codaio
changed the title
When run with a stack of unpushed branches,
av stack submitends up opening a bunch of new browser windows for each PR one by one, which is a bit disruptive.Since we're pushing a single stack, only open the last-created PR once completed.Open all the PRs at the end once created instead.