Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fetch/push upstack branches on av commit create/amend #266

Merged
merged 1 commit into from
May 2, 2024

Conversation

oleg-codaio
Copy link
Contributor

Currently, av commit create and av commit amend will sync dependent branches. This also ends up fetching and pushing to the remote in the process, which isn't expected as the remote gets out of sync as the head branch remains unpushed. Syncing with the remote repo ought to happen separately with av stack sync.

Also added some end to end tests for these commands.

Closes #263.

Copy link
Contributor

aviator-app bot commented May 1, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

aviator-app bot commented May 1, 2024

FlexReview Summary

Based on the code complexity and the author's expertise score, these are the suggested reviewers:

  • @draftcode (current review load: 3)

See the list of alternate reviewers in the detailed breakdown below.

Detailed Breakdown Author’s expertise score for the modified files:
  • cmd/av/commit_amend.go (0.00)
  • cmd/av/commit_create.go (0.00)
  • e2e_tests/commit_amend_test.go (0.00)
  • e2e_tests/commit_create_test.go (0.00)
  • e2e_tests/helpers.go (0.00)
  • internal/actions/sync_stack.go (0.00)
  • internal/git/gittest/commit.go (0.00)
  • internal/git/gittest/files.go (0.00)
Files Reviewers
cmd/av/commit_amend.go †,
cmd/av/commit_create.go †,
e2e_tests/helpers.go
@draftcode (score: 1.00, current review load: 3)

† Indicates that the file doesn't need an expert review. (?)

See full breakdown of the reviewers on the Aviator webapp.

@aviator-app aviator-app bot requested a review from draftcode May 1, 2024 23:54
@aviator-app aviator-app bot merged commit 1b7f930 into aviator-co:master May 2, 2024
4 checks passed
@oleg-codaio oleg-codaio deleted the osv-fix-263 branch May 2, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

av commit create only pushes descendant branches
2 participants