Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #224 #238

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Issue #224 #238

merged 2 commits into from
Mar 28, 2024

Conversation

Konboi
Copy link
Contributor

@Konboi Konboi commented Mar 27, 2024

Hi, this issue (#224) is a "good first issue", so I tried to address it

av commit amend should not fetch or push to remote

Is my change what this issue aims to address? I'd appreciate clarification of the details if my understanding is incorrect.

Thank you.

Copy link
Contributor

aviator-app bot commented Mar 27, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

aviator-app bot commented Mar 27, 2024

FlexReview Summary

Based on the code complexity and the author's expertise score, these are the suggested reviewers:

  • @draftcode (current review load: 4)

See the list of alternate reviewers in the detailed breakdown below.

Detailed Breakdown Author’s expertise score for the modified files:
  • cmd/av/commit_amend.go (0.00)
Files Reviewers
cmd/av/commit_amend.go @draftcode (score: 1.00, current review load: 4),
@ohcnivek (score: 0.36, current review load: 0),
@ErichKramer (score: 0.43, current review load: 2)

† Indicates that the file doesn't need an expert review. (?)

See full breakdown of the reviewers on the Aviator webapp.

@aviator-app aviator-app bot requested a review from draftcode March 27, 2024 13:51
@@ -75,6 +75,10 @@ var commitAmendCmd = &cobra.Command{

branchesToSync := meta.SubsequentBranches(tx, currentBranchName)

// issue #224:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line.

@Konboi
Copy link
Contributor Author

Konboi commented Mar 28, 2024

Thank you for review!

@draftcode
Copy link
Contributor

/aviator merge

Copy link
Contributor

aviator-app bot commented Mar 28, 2024

Aviator has accepted the merge request. It will enter the queue when all of the required status checks have passed. Aviator will update the sticky status comment as the pull request moves through the queue.

@aviator-app aviator-app bot merged commit b771af9 into aviator-co:master Mar 28, 2024
4 checks passed
@Konboi Konboi deleted the issue-224 branch March 28, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants