Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add --reviewers to av pr create #213

Merged
merged 4 commits into from
Nov 27, 2023
Merged

feat: Add --reviewers to av pr create #213

merged 4 commits into from
Nov 27, 2023

Conversation

twavv
Copy link
Contributor

@twavv twavv commented Nov 20, 2023 •
edited
Loading

No description provided.

@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Nov 20, 2023 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@twavv twavv marked this pull request as draft November 20, 2023 23:27
@twavv twavv force-pushed the travis/mer-3175-av-cli-assign-reviewers-with-pr-create-flags branch from 1e07ca3 to 7f508a0 Compare November 20, 2023 23:28
@twavv twavv requested a review from a team November 20, 2023 23:29
@twavv twavv marked this pull request as ready for review November 21, 2023 00:09
jainankit
jainankit reviewed Nov 21, 2023
View reviewed changes
cmd/av/pr_create.go

// Do this after creating the PR and committing the transaction so that
// our local database is up-to-date even if this fails.
if len(prCreateFlags.Reviewers) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't GH allow passing reviewers as part of creating the PR? I wonder if it does, would the behavior be different to do this in two separate steps. Would GH assign some default reviewers still

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't GH allow passing reviewers as part of creating the PR?

The create pull request API (mutation createPullRequest) does not have a way to assign reviewers (nor does the updatePullRequest mutation).

internal/actions/reviewers.go Outdated Show resolved Hide resolved
@aviator-app aviator-app bot merged commit b8c2a31 into master Nov 27, 2023
3 checks passed
@aviator-app aviator-app bot deleted the travis/mer-3175-av-cli-assign-reviewers-with-pr-create-flags branch November 27, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainankit jainankit jainankit approved these changes

@ErichKramer ErichKramer Awaiting requested review from ErichKramer

@draftcode draftcode Awaiting requested review from draftcode

Assignees
No one assigned
Labels
mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twavv @jainankit