Skip to content

Commit

Permalink
fix: Update base branch correctly in av pr create (#206)
Browse files Browse the repository at this point in the history
Fixes a bug where running `av pr create` or `av stack submit` won't edit the base branch of a pull request that already exists.

I noticed this when I reparented a branch that I'd already created a PR for and noticed it didn't set the base branch correctly on GitHub.
  • Loading branch information
twavv authored Oct 23, 2023
1 parent 61dd638 commit bd00516
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions internal/actions/pr.go
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,7 @@ func ensurePR(
PullRequestID: opts.existingPR.ID,
Title: gh.Ptr(githubv4.String(opts.title)),
Body: gh.Ptr(githubv4.String(newBody)),
BaseRefName: gh.Ptr(githubv4.String(opts.baseRefName)),
})
if err != nil {
return nil, false, errors.WithStack(err)
Expand Down

0 comments on commit bd00516

Please sign in to comment.