Experiment with Zod #47
Conversation
scotttrinh
commented
Jul 12, 2023
scotttrinh
commented
- Moves the validation, parsing, and transforming of options into Zod.
- Keeps the defined class to allow consumers of this type to get inline editor docs.
- Some minor project-setup related things, I'll make some comments about this inline.
| @@ -2,7 +2,7 @@ root = true | |||
|
|
|||
| [*] | |||
| charset = utf-8 | |||
| end_of_line = crlf | |||
| end_of_line = lf | |||
There was a problem hiding this comment.
This was causing prettier to rewrite the file I was working on to replace the existing \n with \n\r. Apologies for the tooling churn here, feel free to tell me to revert! Otherwise, I can contribute a small whitespace PR that normalizes on crlf.
| settings: | ||
| autoInstallPeers: true | ||
| excludeLinksFromLockfile: false | ||
|
|
There was a problem hiding this comment.
My version of pnpm (8.3.1) rewrote this file slightly differently. Is there a specific version of pnpm you're using locally so it doesn't do so much rewriting?
There was a problem hiding this comment.
Mine is 8.6.7
I'm not sure if it's significant
|
|
||
| const EdgeOptionsPublishApiSchema = z.object({ | ||
| clientId: z.string({ | ||
| required_error: getErrorMessage(`No client ID is provided. ${messageObtain}`) |
There was a problem hiding this comment.
I left these messages as is, but Zod provides the path to the issue as part of it's error structure, so you can consider just leaning on that.
