Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Watermill #4179

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Add Watermill #4179

merged 1 commit into from
Feb 19, 2023

Conversation

frederikhors
Copy link
Contributor

@frederikhors frederikhors commented Apr 12, 2022

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below that apply before you submit PR.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for detials.

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.
  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documenation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • I have read the Contribution Guidelines, Maintainers Note and Quality Standards.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • The authors of the project do not commit directly to the repo, but rather use pull-requests that run the continuous-integration process.

Thanks for your PR, you're awesome! 👍

@roblaszczak I tried again. We hope.

@avelino
Copy link
Owner

avelino commented Apr 12, 2022

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: True
  • coverage: True

your project is about to be approved, it's under revision, it may take a few days

Copy link
Collaborator

@phanirithvij phanirithvij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • golint
  • gofmt (with -s flag)
  • The documentation is outdated on pkg.go.dev because the last release was ~2 years ago.
  • codecov coverage is out of date (shows coverage for a commit which was made 3 years ago)

@m110
Copy link

m110 commented Apr 15, 2022

Thanks for submitting watermill @frederikhors. Most of the issues mentioned above are already fixed on the master branch. We need to wrap up some more documentation and we're going to release v1.2.0 soon.

Copy link
Owner

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are almost there, your package is just a few steps away from being accepted at awesome-go

@aneshas
Copy link

aneshas commented May 9, 2022

Coverage seems to be at 84% now

@avelino
Copy link
Owner

avelino commented May 9, 2022

Coverage seems to be at 84% now

need review golint

@aneshas
Copy link

aneshas commented May 22, 2022

golint seems to be fine, or am I wrong? (it's not showing up at all in go report card)

@phanirithvij
Copy link
Collaborator

phanirithvij commented May 24, 2022

@m110 @frederikhors please comment here when v1.2.0 is released and when the pkg.go.dev, codecov sites reflect the latest version.

@aneshas you are correct that the golint section is absent in goreportcard, it was removed recently from goreportcard after they bumped the go version to use 1.18 [source].

And codecov is still showing a commit from 2019. The 84% is from the commit from 2019
The latest code coverage is 77% from my fork (with no code changes).

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

This PR has been automatically marked as closed because it has not had recent activity. They will wait 15 days for your interaction, after that the PR will be closed. Please read more in https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md

@github-actions github-actions bot added the stale label Jun 9, 2022
@github-actions github-actions bot closed this Jun 17, 2022
@m110
Copy link

m110 commented Feb 3, 2023

Hey @phanirithvij @avelino

Watermill v1.2.0 has been released now, with codecov, pkg.go.dev and go report card links updated. Can we reopen the PR, please?

@phanirithvij phanirithvij requested a review from avelino February 9, 2023 06:39
@avelino
Copy link
Owner

avelino commented Feb 9, 2023

Screenshot 2023-02-09 at 16 53 33

@m110 the list of files in the coverage system only shows 2 files, is this correct?

@phanirithvij phanirithvij mentioned this pull request Feb 11, 2023
10 tasks
@m110
Copy link

m110 commented Feb 14, 2023

@avelino nice catch, thanks! This should be running correct now.

@phanirithvij phanirithvij merged commit f6f6f6b into avelino:main Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants