-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Watermill #4179
Add Watermill #4179
Conversation
Thank you for contributing with awesome-go, we will revise your contribution as soon as possible. Automation body links content check:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- golint
- gofmt (with -s flag)
- The documentation is outdated on pkg.go.dev because the last release was ~2 years ago.
- codecov coverage is out of date (shows coverage for a commit which was made 3 years ago)
Thanks for submitting watermill @frederikhors. Most of the issues mentioned above are already fixed on the master branch. We need to wrap up some more documentation and we're going to release v1.2.0 soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are almost there, your package is just a few steps away from being accepted at awesome-go
- golint https://goreportcard.com/report/github.com/ThreeDotsLabs/watermill#golint
- coverage
78.99%
, need minimal80%
Coverage seems to be at 84% now |
need review golint |
golint seems to be fine, or am I wrong? (it's not showing up at all in go report card) |
@m110 @frederikhors please comment here when v1.2.0 is released and when the pkg.go.dev, codecov sites reflect the latest version. @aneshas you are correct that the golint section is absent in goreportcard, it was removed recently from goreportcard after they bumped the go version to use 1.18 [source]. And codecov is still showing a commit from 2019. The 84% is from the commit from 2019 |
This PR has been automatically marked as closed because it has not had recent activity. They will wait 15 days for your interaction, after that the PR will be closed. Please read more in https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md |
Watermill v1.2.0 has been released now, with codecov, pkg.go.dev and go report card links updated. Can we reopen the PR, please? |
@m110 the list of files in the coverage system only shows 2 files, is this correct? |
@avelino nice catch, thanks! This should be running correct now. |
Please provide package links to:
Note: that new categories can be added only when there are 3 packages or more.
Make sure that you've checked the boxes below that apply before you submit PR.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for detials.
Thanks for your PR, you're awesome! 👍
@roblaszczak I tried again. We hope.