Refactor features

[ctrlsam]

What kind of change does this PR introduce?

Refactoring

If relevant, did you update the documentation?

Yes, added to README to inform the TMDB proxy is optional, which reduces the complexity of setup for development.

Summary

1. Reduced reused code for features (e.g. Popular, Recently Released, etc) by making the fetch URL dynamic to the type required.
2. Made TMDB PROXY optional - an improvement but could be cleaner
3. Added pagination to Movies section - have not added to others yet as they are not client side components and would need a bit more work, but now allows to seek for more! 🍿

Other information
@avalynndev it may be worth considering making TMDB api calls servers-side only as the current setup leaks API key to clients. BTW love the project, will be happy to contribute to some more work around this, such as moving the fetch requests outside of the component.

Thanks,

Sam.

[netlify]

✅ Deploy Preview for enjoytown ready!

Name	Link
🔨 Latest commit	4569c88
🔍 Latest deploy log	https://app.netlify.com/sites/enjoytown/deploys/6724ec93f30e330008af3dc8
😎 Deploy Preview	https://deploy-preview-150--enjoytown.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[avalynndev]

brother how did u read my brain and do this before i could 0-0

[avalynndev]

Hey sam,
Your changes are very much appreciated. great work!!

• Made TMDB PROXY optional.. was not an idea i would have got.. good work on that
• Reduced reused code for features.. was an idea i wanted to have but was too busy to think about it.. thank a lot for adding it
• Pagination: you have tried to implement this feat but somehow it doesn't work properly 0-0

have a look at the deployment here: https://deploy-preview-150--enjoytown.netlify.app
Kindly try fixing it 0-0.
Thanks,
Avalynndev

[avalynndev]

Regarding the Other Information:
you got a point there.. i am thinking about fetching details similar to plotwist. If you are interested in working on this please try..

Thanks again,
avalynndev

[ctrlsam]

Apart from this Pagination issue.. i think you have forgotten to change the item names for Trending and Popular ANIME.. as there is different items for trending and different for recent anime 0-0

I had a look on the test deploy and it seems that the proxy is not forwarding the page url parameter. What is the reason for the proxy - does the raw TMDB url not work with your hosting provider?

It might be worth trying to implement the site without a proxy as it can add some complexity to the site and challenges, such as observed above. But there may be a reason I'm missing.

Could you elaborate for this one:
"... forgotten to change the item names for Trending and Popular ANIME"

I had a look and wasn't able to figure out what was wrong with the ANIME feature section. Please let me know so I can address it.

Thanks :)

[avalynndev]

hey sam.. i am going out ATM so leave the pagination for now..
in the anime section the rating episodes and description are not being shown for Trending and Popular... check the previous files of anime trending and popular sections for reference..
thanks again

[ctrlsam]

Ahh I see now! I've made a commit that should fix the missing ANIME description and ep. title.

[avalynndev]

Let me look into your code for pagination and try fixing it

[avalynndev]

Changes working

[avalynndev]

@ctrlsam could you work on other features like the ones mentioned in #129 or Upcoming Feat section?
https://github.com/users/avalynndev/projects/1