Add `prefer-t-throws` rule #345

Mesteery · 2022-02-06T01:04:56Z

Fixes: #156

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

#156: Rule proposal: prefer-t-throws

docs/rules/prefer-t-throws.md

sindresorhus · 2022-02-06T04:35:37Z

AVA now has t.throws and t.throwsAsync. See the AVA docs.

test/prefer-t-throws.js

Mesteery · 2022-02-06T11:27:54Z

AVA now has t.throws and t.throwsAsync. See the AVA docs.

So should the rule be t-throws-async instead or should I add another rule?

sindresorhus · 2022-02-06T12:46:08Z

The name should be the what it is, but you need to also support the async method.

rules/prefer-t-throws.js

docs/rules/prefer-t-throws.md

sindresorhus · 2022-02-13T19:00:28Z

rules/prefer-t-throws.js

+const createAvaRule = require('../create-ava-rule');
+const util = require('../util');
+
+// This function checks if there is an AwaitExpression, which is not inside another function.


Maybe you could find an AwaitExpression, then iterate upwards through its parent scopes until you encounter a function, and then check the function.

https://eslint.org/docs/developer-guide/scope-manager-interface

What about the ReturnStatement? I doubt there's anything simpler than that in the end.

Do you have a realistic example of when someone would actually use return in a try/catch when testing an error?

No, I don't have one. It's pretty hard to find a realistic example but I have a feeling that there might be some code written that way.

I have a feeling that there might be some code written that way.

Rule logic should be based on test fixtures, not feelings. My recommendation to simplify the logic here stands.

Fixes: avajs#156

sindresorhus reviewed Feb 6, 2022

View reviewed changes