feat: Adds Tests + Decouples parseAmount fn + fix BigNumber inital parse

.github/workflows/test.yaml

@@ -0,0 +1,18 @@
+name: Test
+on:
+  push:
+    branches-ignore:
+      - main
+jobs:
+  run_tests:
+    runs-on: ubuntu-20.04
+    container: node:20.15-alpine
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Install
+        run: npm install
+      - name: Run tests
+        id: run_node_tests
+        run: |
+            npm run test --verbose

package.json

@@ -6,7 +6,7 @@
   "main": "index.js",
   "type": "module",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1",
+    "test": "node --loader ts-node/esm src/tests/*.ts",
     "build": "tsup",
     "start": "node --experimental-import-meta-resolve dist/index.js",
     "lint": "eslint src/**/*.ts",

src/helpers/parser.ts

@@ -0,0 +1,10 @@
+import { ethers } from "ethers";
+
+export default function parseAmount(numberString: string): string {
+  try {
+    const number = BigInt(numberString);
+    return ethers.formatEther(number).toString();
+  } catch (e) {
+    return "";
+  }
+}

src/services/transaction-cron.ts

@@ -10,6 +10,7 @@ import { decodeParameter, decodeParameters } from "web3-eth-abi";
 import {ethers} from "ethers";
 
 import logger from "../helpers/logger.js";
+import parseAmount from "../helpers/parser.js";
 import {
   IAvailEvent,
   IAvailExtrinsic,
@@ -654,7 +655,7 @@ export default class TransactionCron {
         {
           ...sourceObj(),
           amountPrettified: parseAmount(
-            new BigNumber(value.message.fungibleToken.amount, 16).toString()
+            new BigNumber(value.message.fungibleToken.amount, 16).toFixed()
           ),
         },
         "MessageExecuted"
@@ -681,12 +682,3 @@ export default class TransactionCron {
     }
   }
 }
-
-function parseAmount(numberString: string): string {
-  try {
-    const number = BigInt(numberString);
-    return ethers.formatEther(number).toString();
-  } catch (e) {
-    return "";
-  }
-}

src/tests/parse.test.ts

@@ -0,0 +1,22 @@
+import assert from "assert/strict";
+import { describe, it } from "node:test";
+import { BigNumber } from "bignumber.js";
+import parseAmount from "../helpers/parser.js";
+
+describe("Test tx amount parse", () => {
+  it("Should parse rawFungibleTokenAmount on 18 digit BigNumber value", () => {
+    const rawFungibleTokenAmount = "0x00000000000000000de0b6b3a7640000";
+    const bigNumberString = BigNumber(rawFungibleTokenAmount, 16).toFixed();
+    const amountPrettified = parseAmount(bigNumberString);
+    const expectedParsedAmount = "1.0";
+    assert.deepStrictEqual(amountPrettified, expectedParsedAmount);
+  });
+
+  it("Should parse rawFungibleTokenAmount on 24 digit scientific BigNumber value", () => {
+    const rawFungibleTokenAmount = "0x000000000000182a697403a1b0cf0ad2";
+    const bigNumberString = BigNumber(rawFungibleTokenAmount, 16).toFixed();
+    const amountPrettified = parseAmount(bigNumberString);
+    const expectedParsedAmount = "114119.157542431558142674";
+    assert.deepStrictEqual(amountPrettified, expectedParsedAmount);
+  });
+});