Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-generated SRS loading #328

Merged
merged 11 commits into from
Nov 3, 2023
Merged

Pre-generated SRS loading #328

merged 11 commits into from
Nov 3, 2023

Conversation

ToufeeqP
Copy link
Contributor

@ToufeeqP ToufeeqP commented Oct 27, 2023

Companion PRs:
avail-core PR#58
avail PR#270

@@ -192,7 +192,7 @@ async fn run(error_sender: Sender<anyhow::Error>) -> Result<()> {
#[cfg(feature = "network-analysis")]
tokio::task::spawn(network_analyzer::start_traffic_analyzer(cfg.port, 10));

let pp = Arc::new(kate_recovery::testnet::public_params(1024));
let pp = Arc::new(kate_recovery::testnet_v2::public_params());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the Couscous?

@ToufeeqP ToufeeqP marked this pull request as ready for review November 3, 2023 07:25
Cargo.lock Outdated
"sp-arithmetic 16.0.0",
"sp-core 21.0.0",
"sp-io 23.0.0",
"sp-arithmetic 7.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should revert changes which reduces versions to old ones, it seems that every update switches to old/new versions randomly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, No idea why this is happening. but will revert it

Copy link
Contributor

@aterentic-ethernal aterentic-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think we should update public parameters in test, but not 100% sure.

@ToufeeqP ToufeeqP merged commit 4c99cae into main Nov 3, 2023
1 check passed
@ToufeeqP ToufeeqP deleted the toufeeq/srs-loading branch November 3, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants