Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spec_version check. #251

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Conversation

aterentic-ethernal
Copy link
Contributor

Reasoning behind this change should be in matches method comment.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Patch coverage: 50.38% and project coverage change: -0.85% ⚠️

Comparison is base (0900dd2) 26.27% compared to head (3f06618) 25.43%.
Report is 11 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   26.27%   25.43%   -0.85%     
==========================================
  Files          22       22              
  Lines        6153     6385     +232     
==========================================
+ Hits         1617     1624       +7     
- Misses       4536     4761     +225     
Files Changed Coverage Δ
src/data.rs 20.20% <0.00%> (-5.64%) ⬇️
src/main.rs 0.42% <0.00%> (+<0.01%) ⬆️
src/network/client.rs 0.00% <0.00%> (ø)
src/subscriptions.rs 0.00% <0.00%> (ø)
src/types.rs 19.48% <0.00%> (+0.14%) ⬆️
src/sync_client.rs 44.02% <18.18%> (-0.27%) ⬇️
src/app_client.rs 39.39% <44.44%> (+0.51%) ⬆️
src/rpc.rs 37.50% <56.41%> (+7.88%) ⬆️
src/light_client.rs 61.60% <83.33%> (ø)
src/utils.rs 17.23% <84.37%> (+1.63%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aterentic-ethernal aterentic-ethernal merged commit b96e382 into main Aug 7, 2023
1 check passed
@aterentic-ethernal aterentic-ethernal deleted the remove-spec-version-check branch August 7, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants