Ghali/substrate and padding #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 59.21% 57.34% -1.87%
==========================================
Files 56 58 +2
Lines 8049 8416 +367
==========================================
+ Hits 4766 4826 +60
- Misses 3283 3590 +307 ☔ View full report in Codecov by Sentry. |
core/src/header_version/mod.rs
Outdated
| #[cfg_attr(feature = "runtime", derive(PassByCodec))] | ||
| pub enum HeaderVersion { | ||
| V1, // Current one | ||
| V2, // To be used after runtime upgrade (new data_root) |
There was a problem hiding this comment.
This should be the current one
There was a problem hiding this comment.
Since it is not used yet, did not want to introduce confusion
markopoloparadox
approved these changes
Jan 17, 2024
ToufeeqP
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One branch for substrate upgrade and removing useless padding value + header v3
Those two branch will not be merged.