add validator state #1344
Open
add validator state #1344
+647
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
darioush
reviewed
Sep 17, 2024
go.mod
Outdated
| @@ -5,7 +5,7 @@ go 1.21.12 | |||
| require ( | |||
| github.com/VictoriaMetrics/fastcache v1.12.1 | |||
| github.com/antithesishq/antithesis-sdk-go v0.3.8 | |||
| github.com/ava-labs/avalanchego v1.11.11 | |||
| github.com/ava-labs/avalanchego v1.11.12-0.20240910093928-8c6a486205ce | |||
There was a problem hiding this comment.
Could you link the modified avalanchego branch in the PR description?
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
|
Changed the target branch to |
darioush
reviewed
Sep 19, 2024
plugin/evm/validators/state_test.go
Outdated
| IsActive: true, | ||
| }, | ||
| }, | ||
| { | ||
| name: "invalid codec version", | ||
| name: " ", |
There was a problem hiding this comment.
seems this was modified unintentionally
darioush
reviewed
Sep 19, 2024
plugin/evm/validators/state_test.go
Outdated
|
|
||
| // write state, should reflect to DB | ||
| require.NoError(state.WriteState()) | ||
| require.True(db.Has(vID[:])) | ||
|
|
||
| // set uptime | ||
| newUpDuration := 2 * time.Minute | ||
| newuptime := 2 * time.Minute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds validator state that can persist validator information and implements
uptime.State.How this was tested
Added UT
How is this documented
Comments in code