Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Enable collection of logs and metrics #1122

Merged
merged 2 commits into from
Mar 27, 2024
Merged

ci: Enable collection of logs and metrics #1122

merged 2 commits into from
Mar 27, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Mar 12, 2024 •
edited
Loading

Why this should be merged

Adds collection of logs and metrics for warp and load testing to aid in debugging.

How this works

  • starts agent-mode prometheus and promtail before the test run
  • tmpnet writes prometheus and promtail configuration when starting nodes
  • ci jobs are configured with the environment necessary to label metrics

How this was tested

  • Checked that links emitted by the 2 jobs using tmpnet opened a grafana page that was correctly filtered and contained data for the test run
  • Checked that a manual loki query was possible

How is this documented

  • Added brief overview to tests/README.md with a link to the relevant avalanchego docs. There is an outstanding PR that improves the relevant avalanchego docs.

TODO

@marun marun force-pushed the ci-monitoring branch 2 times, most recently from 7b934e9 to a84b274 Compare March 12, 2024 20:00
@marun marun mentioned this pull request Mar 13, 2024
Closed
@marun marun added the ci label Mar 15, 2024
@marun marun self-assigned this Mar 15, 2024
@marun marun changed the title ci: Enable metrics collection ci: Enable collection of logs and metrics Mar 18, 2024
@marun marun force-pushed the ci-monitoring branch 4 times, most recently from c1602f3 to e02f1d7 Compare March 19, 2024 19:02
@marun marun mentioned this pull request Mar 20, 2024
Merged
@marun marun force-pushed the ci-monitoring branch 2 times, most recently from caa2d90 to f2cea7b Compare March 22, 2024 17:01
@marun marun changed the base branch from master to bump-avago March 22, 2024 17:01
@marun
Copy link
Contributor Author

marun commented Mar 22, 2024

Changed base to #1130

Base automatically changed from bump-avago to master March 25, 2024 19:00
@marun
Copy link
Contributor Author

marun commented Mar 26, 2024

Rebased

@marun marun marked this pull request as ready for review March 26, 2024 08:36
ceyonur
ceyonur approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@darioush darioush merged commit 1f5b595 into master Mar 27, 2024
9 checks passed
@darioush darioush deleted the ci-monitoring branch March 27, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioush darioush darioush approved these changes

@ceyonur ceyonur ceyonur approved these changes

Assignees

@marun marun

Labels
ci
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marun @darioush @ceyonur