Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geth v1.13.2 #1116

Closed
wants to merge 10,000 commits into from
Closed

Geth v1.13.2 #1116

wants to merge 10,000 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    9d744f0 View commit details
    Browse the repository at this point in the history
  2. all: implement path-based state scheme (#25963)

    * all: implement path-based state scheme
    
    * all: edits from review
    
    * core/rawdb, trie/triedb/pathdb: review changes
    
    * core, light, trie, eth, tests: reimplement pbss history
    
    * core, trie/triedb/pathdb: track block number in state history
    
    * trie/triedb/pathdb: add history documentation
    
    * core, trie/triedb/pathdb: address comments from Peter's review
    
    Important changes to list:
    
    - Cache trie nodes by path in clean cache
    - Remove root->id mappings when history is truncated
    
    * trie/triedb/pathdb: fallback to disk if unexpect node in clean cache
    
    * core/rawdb: fix tests
    
    * trie/triedb/pathdb: rename metrics, change clean cache key
    
    * trie/triedb: manage the clean cache inside of disk layer
    
    * trie/triedb/pathdb: move journal function
    
    * trie/triedb/path: fix tests
    
    * trie/triedb/pathdb: fix journal
    
    * trie/triedb/pathdb: fix history
    
    * trie/triedb/pathdb: try to fix tests on windows
    
    * core, trie: address comments
    
    * trie/triedb/pathdb: fix test issues
    
    ---------
    
    Co-authored-by: Felix Lange <[email protected]>
    Co-authored-by: Martin Holst Swende <[email protected]>
    3 people authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    7de748d View commit details
    Browse the repository at this point in the history
  3. cmd/geth: disable automaxprocs log (#27814)

    Co-authored-by: Felix Lange <[email protected]>
    jsvisa and fjl authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ff97b4c View commit details
    Browse the repository at this point in the history
  4. p2p: use atomic types (#27764)

    Co-authored-by: Felix Lange <[email protected]>
    ucwong and fjl authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d04bde0 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Configuration menu
    Copy the full SHA
    8224bb9 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    6e934f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. core/types: fix immutability guarantees in Block (#27844)

    This change rearranges the accessor methods in block.go and fixes some minor issues with
    the copy-on-write logic of block data. Fixed issues:
    
    - Block.WithWithdrawals did not create a shallow copy of the block.
    
    - Block.WithBody copied the header unnecessarily, and did not preserve withdrawals.
    
    However, the bugs did not affect any code in go-ethereum because blocks are *always*
    created using NewBlockWithHeader().WithBody().WithWithdrawals()
    fjl authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    df54435 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    57cdbae View commit details
    Browse the repository at this point in the history
  3. core/types: support yParity field in JSON transactions (#27744)

    This adds support for the "yParity" field in transaction objects returned by RPC
    APIs. We somehow forgot to add this field even though it has been in the spec for
    a long time.
    fjl authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    bb148dd View commit details
    Browse the repository at this point in the history
  4. log: use atomic types (#27763)

    Co-authored-by: Felix Lange <[email protected]>
    ucwong and fjl authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5c30541 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    60070fe View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Configuration menu
    Copy the full SHA
    8574767 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d14c07d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eeebb07 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6d2bcb9 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. graphql: avoid greedy allocation (#27873)

    Fixes a graphql-dos
    
    ---------
    
    Co-authored-by: Sina Mahmoodi <[email protected]>
    Co-authored-by: Sina Mahmoodi <[email protected]>
    3 people authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0d772b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e13fa32 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. p2p: move ping handling into pingLoop goroutine (#27887)

    Moving the response sending there allows tracking all peer goroutines
    in the peer WaitGroup.
    fjl authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    7ec60d5 View commit details
    Browse the repository at this point in the history
  2. graphql: add yParity field for transactions (#27882)

    Co-authored-by: Felix Lange <[email protected]>
    jsvisa and fjl authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    10d9f93 View commit details
    Browse the repository at this point in the history
  3. core/state: move UpdateContractCode before the trie hash is computed …

    …(#27853)
    
    Context: The UpdateContractCode method was introduced for the state storage commitment
    schemes that include the whole code for their commitment computation. It must therefore be called
    before the root hash is computed at the end of IntermediateRoot.
    
    This should have no impact on the MPT since, in this context, the method is a no-op.
    gballet authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6797902 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Configuration menu
    Copy the full SHA
    9c216bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9a8b0f View commit details
    Browse the repository at this point in the history
  3. eth/filters, core/rawdb: remove unused param, refactor filtering-loop…

    … (#27891)
    
    This change removes a chainconfig parameter passed into rawdb.ReadLogs, which is not used nor needed.
    It also modifies the filter loop slightly, avoiding a labeled break and instead using a method.
    
    This change does not modify any behaviour.
    holiman authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    8d1db16 View commit details
    Browse the repository at this point in the history
  4. deps: update supranational/blst to 0.3.11 (#27890)

    build(deps): bump github.com/supranational/blst
    
    Bumps [github.com/supranational/blst](https://github.com/supranational/blst) from 0.3.11-0.20230406105308-e9dfc5ee724b to 0.3.11.
    - [Release notes](https://github.com/supranational/blst/releases)
    - [Commits](https://github.com/supranational/blst/commits/v0.3.11)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/supranational/blst
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    86d7f5a View commit details
    Browse the repository at this point in the history
  5. graphql: validate block params (#27876)

    Block takes a number and a hash. The spec is unclear on what should happen in this case, leaving it an implemenation detail. With this change, we return an error in case both number and hash are passed in.
    s1na authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5e89ff4 View commit details
    Browse the repository at this point in the history
  6. all: activate pbss as experimental feature (#26274)

    * all: activate pbss
    
    * core/rawdb: fix compilation error
    
    * cma, core, eth, les, trie: address comments
    
    * cmd, core, eth, trie: polish code
    
    * core, cmd, eth: address comments
    
    * cmd, core, eth, les, light, tests: address comment
    
    * cmd/utils: shorten log message
    
    * trie/triedb/pathdb: limit node buffer size to 1gb
    
    * cmd/utils: fix opening non-existing db
    
    * cmd/utils: rename flag name
    
    * cmd, core: group chain history flags and fix tests
    
    * core, eth, trie: fix memory leak in snapshot generation
    
    * cmd, eth, internal: deprecate flags
    
    * all: enable state tests for pathdb, fixes
    
    * cmd, core: polish code
    
    * trie/triedb/pathdb: limit the node buffer size to 256mb
    
    ---------
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    Co-authored-by: Péter Szilágyi <[email protected]>
    3 people authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    503f1f7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e2507a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Configuration menu
    Copy the full SHA
    6ddb92c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    35f7f3d View commit details
    Browse the repository at this point in the history
  3. rpc: attempt to fix ping/pong logic race (#27733)

    This should fix #27726. With enough load, it might happen that the SetPongHandler 
    callback gets invoked before the call to SetReadDeadline is made in pingLoop. When 
    this occurs, the socket will end up with a 30s read deadline even though it got the pong,
    which will lead to a timeout.
    
    The fix here is processing the pong on pingLoop, synchronizing with the code that 
    sends the ping.
    fjl authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    8f8ef2b View commit details
    Browse the repository at this point in the history
  4. core/types: remove duplication in eip2930 signer (#27860)

    Remove duplication in signer
    ---------
    
    Co-authored-by: GDdark <[email protected]>
    Co-authored-by: Felix Lange <[email protected]>
    3 people authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    80b76a9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0ce331f View commit details
    Browse the repository at this point in the history
  6. all: update golang/x/ext and fix slice sorting fallout (#27909)

    The Go authors updated golang/x/ext to change the function signature of the slices sort method. 
    It's an entire shitshow now because x/ext is not tagged, so everyone's codebase just 
    picked a new version that some other dep depends on, causing our code to fail building.
    
    This PR updates the dep on our code too and does all the refactorings to follow upstream...
    karalabe authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    be65b47 View commit details
    Browse the repository at this point in the history
  7. deps: update supranational/blst to 0.3.11 (#27890)

    build(deps): bump github.com/supranational/blst
    
    Bumps [github.com/supranational/blst](https://github.com/supranational/blst) from 0.3.11-0.20230406105308-e9dfc5ee724b to 0.3.11.
    - [Release notes](https://github.com/supranational/blst/releases)
    - [Commits](https://github.com/supranational/blst/commits/v0.3.11)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/supranational/blst
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and fjl committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a0491a0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    55863ce View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    770db14 View commit details
    Browse the repository at this point in the history
  10. all: update golang/x/ext and fix slice sorting fallout (#27909)

    The Go authors updated golang/x/ext to change the function signature of the slices sort method. 
    It's an entire shitshow now because x/ext is not tagged, so everyone's codebase just 
    picked a new version that some other dep depends on, causing our code to fail building.
    
    This PR updates the dep on our code too and does all the refactorings to follow upstream...
    karalabe authored and fjl committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    811a674 View commit details
    Browse the repository at this point in the history
  11. go.mod, build: upgrade c-kzg-4844 (#27907)

    This upgrades to the latest release of ckzg, and also attempts to fix some blst-related
    build errors that occur on launchpad.net.
    fjl authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e91b21c View commit details
    Browse the repository at this point in the history
  12. go.mod, build: upgrade c-kzg-4844 (#27907)

    This upgrades to the latest release of ckzg, and also attempts to fix some blst-related
    build errors that occur on launchpad.net.
    fjl committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f298ec4 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Configuration menu
    Copy the full SHA
    6886006 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a867039 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bed8460 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. core/types: support for optional blob sidecar in BlobTx (#27841)

    This PR removes the newly added txpool.Transaction wrapper type, and instead adds a way
    of keeping the blob sidecar within types.Transaction. It's better this way because most
    code in go-ethereum does not care about blob transactions, and probably never will. This
    will start mattering especially on the client side of RPC, where all APIs are based on
    types.Transaction. Users need to be able to use the same signing flows they already
    have.
    
    However, since blobs are only allowed in some places but not others, we will now need to
    add checks to avoid creating invalid blocks. I'm still trying to figure out the best place
    to do some of these. The way I have it currently is as follows:
    
    - In block validation (import), txs are verified not to have a blob sidecar.
    - In miner, we strip off the sidecar when committing the transaction into the block.
    - In TxPool validation, txs must have a sidecar to be added into the blobpool.
      - Note there is a special case here: when transactions are re-added because of a chain
        reorg, we cannot use the transactions gathered from the old chain blocks as-is,
        because they will be missing their blobs. This was previously handled by storing the
        blobs into the 'blobpool limbo'. The code has now changed to store the full
        transaction in the limbo instead, but it might be confusing for code readers why we're
        not simply adding the types.Transaction we already have.
    
    Code changes summary:
    
    - txpool.Transaction removed and all uses replaced by types.Transaction again
    - blobpool now stores types.Transaction instead of defining its own blobTx format for storage
    - the blobpool limbo now stores types.Transaction instead of storing only the blobs
    - checks to validate the presence/absence of the blob sidecar added in certain critical places
    fjl authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    2a6beb6 View commit details
    Browse the repository at this point in the history
  2. cmd/utils: restore support for txlookuplimit flag (#27917)

    This fixes a regression where -txlookuplimit was not applied anymore.
    jsvisa authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    6885521 View commit details
    Browse the repository at this point in the history
  3. go.mod: upgrade goja (#27899)

    ucwong authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    509cd42 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Configuration menu
    Copy the full SHA
    f1801a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    05a8b88 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ab28680 View commit details
    Browse the repository at this point in the history
  4. eth/tracers/js: use t.toBig on ctx.GasPrice for js tracing (#27903)

    This change fixes a bug in js tracer, where `ctx.GasPrice.toString(16)` returns a number string in base `10`.
    nettijoe96 authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e0b1198 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Configuration menu
    Copy the full SHA
    a16d757 View commit details
    Browse the repository at this point in the history
  2. node: increase batch limits for auth rpc API (#27924)

    This raises the JSON-RPC batch request limits significantly for the engine API endpoint.
    The limits are now also hard-coded, so users won't get them wrong. I have chosen these limits:
    
        maximum batch items: 2000
        maximum batch response size: 250MB
    
    While it would also be possible to disable batch limits completely for the engine API, 
    I think having some limits is a good safety net against misbehaving CLs. Since this
     isn't configurable, we really want to ensure this limit will never become an issue in the
     CL/EL communication, so I set them quite high.
    
    ---------
    
    Signed-off-by: jsvisa <[email protected]>
    Co-authored-by: Felix Lange <[email protected]>
    jsvisa and fjl authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    386cba1 View commit details
    Browse the repository at this point in the history
  3. core/types: fix unmarshalling of BlobTx values (#27939)

    FromBig returns true *when overflow occurs*
    lightclient authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a3e3541 View commit details
    Browse the repository at this point in the history
  4. core/forkid: correctly compute forkid when timestamp fork is activate…

    …d in genesis (#27895)
    
    This changes the forkID calculation to ignore time-based forks that occurred before the
    genesis block. It's supposed to be done this way because the spec says:
    
    > If a chain is configured to start with a non-Frontier ruleset already in its genesis, that is NOT considered a fork.
    lightclient authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    32fde3f View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. core/txpool/legacypool: protect cache with mutex (#27898)

    This change fixes the a potential race by using mutexes when the m.cache is read or modified.
    holiman authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    1aa5520 View commit details
    Browse the repository at this point in the history
  2. eth/downloader: fix rare crash when parent header missing in db (#27945)

    ReadSkeletonHeader can return nil if the header is missing, so we should
    not access fields on it. Note that calling .Hash() on a nil header is fine, so there 
    is no need to actually check for nil.
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    jsvisa and holiman authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    649deb6 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. internal/ethapi: optimize & clean up EstimateGas (#27710)

    Optimizations:
    
    - Previously, if a transaction was reverting, EstimateGas would exhibit worst-case behavior and binary search up to the max gas limit (~40 state-clone + tx executions). This change allows EstimateGas to return after only a single unconstrained execution in this scenario.
    - Uses the gas used from the unconstrained execution to bias the remaining binary search towards the likely solution in a simple way that doesn't impact the worst case. For a typical contract-invoking transaction, this reduces the median number of state-clone+executions from 25 to 18 (28% reduction).
    
    Cleanup:
    
    - added & improved function + code comments
    - correct the EstimateGas documentation to clarify the gas limit determination is at latest block, not pending, if the blockNr is unspecified.
    roberto-bayardo authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    950ccdd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7dea9c1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5976e58 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    b3024e8 View commit details
    Browse the repository at this point in the history
  2. eth/catalyst: set finalized block hash properly in dev mode (#27886)

    
    Co-authored-by: Martin Holst Swende <[email protected]>
    jwasinger and holiman authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    f56ee7d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. internal/ethapi: add testcases for blobTx (#27818)

    Co-authored-by: Martin Holst Swende <[email protected]>
    jsvisa and holiman authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9f4a528 View commit details
    Browse the repository at this point in the history
  2. core: ensure txindex will be triggered at least once (#27847)

    Currently, we trigger the logic to (un)index transactions when the node receives a new
    block. However, in some cases the node may not receive new blocks (eg, when the Geth node
    is configured without peer discovery, or when it acts as an RPC node for historical-only
    data).
    
    In these situations, the Geth node user may not have previously configured txlookuplimit
    (i.e. the default of around one year), but later realizes they need to index all
    historical blocks. However, adding txlookuplimit=0 and restarting geth has no effect. This
    change makes it check for required indexing work once, on startup, to fix the issue.
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    jsvisa and holiman authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7c0d90c View commit details
    Browse the repository at this point in the history
  3. miner: fix reply -> replay typo (#27961)

    * typo: reply -> replay
    
    * rebuild
    shuoli84 authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    bbee0e7 View commit details
    Browse the repository at this point in the history
  4. travis, build: update Go to 1.21.0 (#27958)

    build: update to go 1.21
    holiman authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    55c5f59 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0b4b299 View commit details
    Browse the repository at this point in the history
  6. core, params, beacon/engine: implement EIP 4788 BeaconRoot (#27849)

    This change implements "EIP 4788 : Beacon block root in the EVM". It implements version-2 of EPI-4788, main difference being that the contract is an actual contract rather than a precompile, as in #27289.
    holiman authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b8d38e7 View commit details
    Browse the repository at this point in the history
  7. cmd/evm: add back stateroot to jsonl-output (#27968)

    The PR #26274 broke the evm statetest command a bit, in that it stopped spitting out the stateroot following a non-successful statetest-execution. 
    
    This PR changes it back, so the stateroot is unconditionally output on stderr, and makes it so fuzzing works again.
    holiman authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8d24929 View commit details
    Browse the repository at this point in the history
  8. core: add BeaconRoot to header in GenerateChain (#27974)

    Fixes an error in tests of internal/ethapi.
    fjl authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    4c7053b View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. rpc: use go-winio for named pipes (#27972)

    We're trying a new named pipe library, which should hopefully fix some occasional failures in CI.
    
    ---------
    
    Co-authored-by: Felix Lange <[email protected]>
    holiman and fjl authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    16946d2 View commit details
    Browse the repository at this point in the history
  2. graphql: fix nil deref on a timer (#27978)

    graphql: fix the panic of nil timer.Stop
    
    Signed-off-by: jsvisa <[email protected]>
    jsvisa authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c31f9cf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ab3762b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0c6bbeb View commit details
    Browse the repository at this point in the history
  5. eth/catalyst: disable full payload when not in dev mode (#27921)

    eth/catalyst: only enable full payload in dev mode
    rjl493456442 authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    bce5c46 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    00fead9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4af98d4 View commit details
    Browse the repository at this point in the history
  8. account/abi: convert if-else-if chain to tagged switch (#27869)

    account/abi: conver if-else-if chain to tagged switch
    islishude authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    76d4ac1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    52219ce View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5c7136a View commit details
    Browse the repository at this point in the history
  11. core/rawdb, ethdb/pebble: avoid fsync db in tests (#27836)

    Adds an option to disable fsync for database operations.
    This is to make tests faster.
    holiman authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f0f8703 View commit details
    Browse the repository at this point in the history
  12. les: use new atomic types (#27856)

    Co-authored-by: Felix Lange <[email protected]>
    ucwong and fjl authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    e3f3e01 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    4abc412 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2f4dbb4 View commit details
    Browse the repository at this point in the history
  15. core/state: remove public method ForEachStorage (#27986)

    Co-authored-by: Felix Lange <[email protected]>
    holiman and fjl authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    eb6cbe3 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    d1f6735 View commit details
    Browse the repository at this point in the history
  17. miner: add to build block with EIP-4844 blobs (#27875)

    
    ---------
    
    Co-authored-by: Marius van der Wijden <[email protected]>
    Co-authored-by: Felix Lange <[email protected]>
    3 people authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    feb8f41 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    60ec41c View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    9b46986 View commit details
    Browse the repository at this point in the history
  2. eth/catalyst: disable heartbeat for simulated beacon node (#27979)

    * eth/catalyst: disable heartbeat for simulated beacon node
    
    Signed-off-by: jsvisa <[email protected]>
    
    * eth/catalyst: update
    
    * eth/catalyst: disable heartbeat for tester
    
    ---------
    
    Signed-off-by: jsvisa <[email protected]>
    Co-authored-by: Felix Lange <[email protected]>
    Co-authored-by: Gary Rong <[email protected]>
    3 people authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    45b198d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1a21350 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Configuration menu
    Copy the full SHA
    0ba2d3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    56d2366 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6dc9cdf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5e0eb62 View commit details
    Browse the repository at this point in the history
  5. cmd, core, params: add support for the Holesky testnet (#28007)

    * cmd, core, params: add support for the Holesky testnet
    
    * cmd/devp2p: add support for holesky for the dns crawler
    karalabe authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    6b98d18 View commit details
    Browse the repository at this point in the history
  6. core/types: transaction and receipt encoding/decoding optimizations (…

    …#27976)
    
    Just some minor optimizations I figured out a while ago. By using ReadBytes instead of
    Bytes on the rlp stream, we can save the allocation of a temporary buffer for the typed tx
    payload.
    
    If kind == rlp.Byte, the size reported by Stream.Kind will be zero, but we need a buffer
    of size 1 for ReadBytes. Since typed txs always have to be longer than 1 byte, we can just
    return an error for kind == rlp.Byte.
    
    There is a also a small change for Log: since the first three fields of Log are the ones that 
    should appear in the canon encoding, we can simply ignore the remaining fields via 
    struct tag. Doing this removes an indirection through the rlpLog type.
    
    ---------
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    fjl and holiman authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    9bbb9df View commit details
    Browse the repository at this point in the history
  7. eth/catalyst: reset to current header if chain is rewound (in dev mod…

    …e) (#27992)
    
    
    
    Signed-off-by: jsvisa <[email protected]>
    Co-authored-by: Jared Wasinger <[email protected]>
    jsvisa and jwasinger authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    cde462c View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. beacon/engine, eth/catalyst, miner: EIP-4788 CL/EL protocol updates (…

    …#27872)
    
    This PR makes EIP-4788 work in the engine API and miner. It also fixes some bugs related to 
    EIP-4844 block processing and mining. Changes in detail:
    
    - Header.BeaconRoot has been renamed to ParentBeaconRoot.
    - The engine API now implements forkchoiceUpdatedV3
    - newPayloadV3 method has been updated with the parentBeaconBlockRoot parameter
    - beacon root is now applied to new blocks in miner
    - For EIP-4844, block creation now updates the blobGasUsed field of the header
    holiman authored Aug 26, 2023
    Configuration menu
    Copy the full SHA
    6aa88cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ca7fb8 View commit details
    Browse the repository at this point in the history
  3. core/state: implement fast storage deletion (#27955)

    This changes implements faster post-selfdestruct iteration of storage slots for deletion, by using snapshot-storage+stacktrie to recover the trienodes to be deleted. This mechanism is only implemented for path-based schema. 
    
    For hash-based schema, the entire post-selfdestruct storage iteration is skipped, with this change, since hash-based does not actually perform deletion anyway. 
    
    ---------
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    rjl493456442 and holiman authored Aug 26, 2023
    Configuration menu
    Copy the full SHA
    3ff6b3c View commit details
    Browse the repository at this point in the history
  4. eth: remove check for tdd reached on pos api block tags (#27799)

    This change defers to the blockchain for in what circumstances to return error, instead of handling many error-cases in the api backend.
    lightclient authored Aug 26, 2023
    Configuration menu
    Copy the full SHA
    3a662d4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d4e345c View commit details
    Browse the repository at this point in the history
  6. build, tests: add execution-spec-tests (#26985)

    This makes it possible to run the execution-spec-tests (a.k.a. pyspec) in CI.
    
    ---------
    
    Co-authored-by: Felix Lange <[email protected]>
    MariusVanDerWijden and fjl authored Aug 26, 2023
    Configuration menu
    Copy the full SHA
    f174ddb View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. miner/stress/clique: fix typo (#28016)

    fix typo
    Cr4shOv3rrid3 authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    fe24d22 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. tests: use 'sender' in state tests if present (#28023)

    A while back, statetests started coming with sender baked in, which at least 
    evmone makes use of. Let's make use of that too, and save some cycles.
    holiman authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    b8adb4c View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Configuration menu
    Copy the full SHA
    41ee96f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Configuration menu
    Copy the full SHA
    5b15949 View commit details
    Browse the repository at this point in the history
  2. metrics, cmd/geth: informational metrics (prometheus, influxdb, opent…

    …sb) (#24877)
    
    This chang creates a GaugeInfo metrics type for registering informational (textual) metrics, e.g. geth version number. It also improves the testing for backend-exporters, and uses a shared subpackage in 'internal' to provide sample datasets and ordered registry. 
    
    Implements #21783
    
    ---------
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    jorgeacortes and holiman authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    53f3c2a View commit details
    Browse the repository at this point in the history
  3. core/state: simplify storage trie update and commit (#28030)

    This change improves function description and simplifies logic in statedb update and commit operations.
    rjl493456442 authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    0acc0a1 View commit details
    Browse the repository at this point in the history
  4. eth/catalyst: set random value in dev mode (#27940)

    * eth/catalyst: set random
    
    * Apply suggestions from code review
    
    ---------
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    MariusVanDerWijden and holiman authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    2885708 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. beacon/engine: add shouldOverrideBuilder to payload envelope (#28029)

    beacon/engine: add shouldOverrideBuilder to payload envelope
    lightclient authored Sep 4, 2023
    Configuration menu
    Copy the full SHA
    f260a9e View commit details
    Browse the repository at this point in the history
  2. core/forkid: skip genesis forks by time (#28034)

    * core/forkid: skip genesis forks by time
    
    * core/forkid: add comment about skipping non-zero fork times
    
    * core/forkid: skip all time based forks in genesis using loop
    
    * core/forkid: simplify logic for dropping time-based forks
    lightclient authored Sep 4, 2023
    Configuration menu
    Copy the full SHA
    eff7c3b View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. params: update 4844 parameters (#28026)

    On ACD 163, it was agreed to bump the target and max blob values from `2/4` to `3/6` for future devnets until we could decide on final mainnet number. This change contains said update, making master pass all the hive tests. The final decision for mainnet cancun is still to be made.
    ---------
    
    Co-authored-by: Felix Lange <[email protected]>
    lightclient and fjl authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    25733a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Configuration menu
    Copy the full SHA
    2f77299 View commit details
    Browse the repository at this point in the history
  2. core/rawdb: don't warn for missing "unclean shutdown markers" (#28014)

    This changes removes the warn-printout about not finding unclean shutdown markers, which always happens on fresh installs / wiped databases.
    jsvisa authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    2e02c1f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. deps: update minisign (#28066)

    This updates minisign to the latest version. One new thing is that minisign (not go-minisign) has started to prehash the file, and in order to make geth pass the version-check, we need to sign the file in legacy-mode.
    holiman authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    c60f7dd View commit details
    Browse the repository at this point in the history
  2. log: avoid stack lookups when not needed/used (#28069)

     Avoids the somewhat expensive stack.Caller invocation by checking if it is needed
    holiman authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a8d7201 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a7842c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Configuration menu
    Copy the full SHA
    83886e4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5cf53f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. core: fix calculation of blob gasprice in tx receipt (#28082)

    This fixes the derived value BlobGasPrice on the receipt of EIP-4844 transactions, which was previously erroneously set to the price cap.
    lightclient authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    1efd12f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    12ef276 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. params: release Geth v1.13.0

    karalabe committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7371b38 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    766272f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Configuration menu
    Copy the full SHA
    43df612 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d38b1f View commit details
    Browse the repository at this point in the history
  3. metrics: refactor metrics (#28035)

    This change includes a lot of things, listed below. 
    
    ### Split up interfaces, write vs read
    
    The interfaces have been split up into one write-interface and one read-interface, with `Snapshot` being the gateway from write to read. This simplifies the semantics _a lot_. 
    
    Example of splitting up an interface into one readonly 'snapshot' part, and one updatable writeonly part: 
    
    ```golang
    type MeterSnapshot interface {
    	Count() int64
    	Rate1() float64
    	Rate5() float64
    	Rate15() float64
    	RateMean() float64
    }
    
    // Meters count events to produce exponentially-weighted moving average rates
    // at one-, five-, and fifteen-minutes and a mean rate.
    type Meter interface {
    	Mark(int64)
    	Snapshot() MeterSnapshot
    	Stop()
    }
    ```
    
    ### A note about concurrency
    
    This PR makes the concurrency model clearer. We have actual meters and snapshot of meters. The `meter` is the thing which can be accessed from the registry, and updates can be made to it. 
    
    - For all `meters`, (`Gauge`, `Timer` etc), it is assumed that they are accessed by different threads, making updates. Therefore, all `meters` update-methods (`Inc`, `Add`, `Update`, `Clear` etc) need to be concurrency-safe. 
    - All `meters` have a `Snapshot()` method. This method is _usually_ called from one thread, a backend-exporter. But it's fully possible to have several exporters simultaneously: therefore this method should also be concurrency-safe. 
    
    TLDR: `meter`s are accessible via registry, all their methods must be concurrency-safe. 
    
    For all `Snapshot`s, it is assumed that an individual exporter-thread has obtained a `meter` from the registry, and called the `Snapshot` method to obtain a readonly snapshot. This snapshot is _not_ guaranteed to be concurrency-safe. There's no need for a snapshot to be concurrency-safe, since exporters should not share snapshots. 
    
    Note, though: that by happenstance a lot of the snapshots _are_ concurrency-safe, being unmutable minimal representations of a value. Only the more complex ones are _not_ threadsafe, those that lazily calculate things like `Variance()`, `Mean()`.
    
    Example of how a background exporter typically works, obtaining the snapshot and sequentially accessing the non-threadsafe methods in it: 
    ```golang
    		ms := metric.Snapshot()
                    ...
    		fields := map[string]interface{}{
    			"count":    ms.Count(),
    			"max":      ms.Max(),
    			"mean":     ms.Mean(),
    			"min":      ms.Min(),
    			"stddev":   ms.StdDev(),
    			"variance": ms.Variance(),
    ```
    
    TLDR: `snapshots` are not guaranteed to be concurrency-safe (but often are).
    
    ### Sample changes
    
    I also changed the `Sample` type: previously, it iterated the samples fully every time `Mean()`,`Sum()`, `Min()` or `Max()` was invoked. Since we now have readonly base data, we can just iterate it once, in the constructor, and set all four values at once. 
    
    The same thing has been done for runtimehistogram. 
    
    ### ResettingTimer API
    
    Back when ResettingTImer was implemented, as part of ethereum/go-ethereum#15910, Anton implemented a `Percentiles` on the new type. However, the method did not conform to the other existing types which also had a `Percentiles`. 
    
    1. The existing ones, on input, took `0.5` to mean `50%`. Anton used `50` to mean `50%`. 
    2. The existing ones returned `float64` outputs, thus interpolating between values. A value-set of `0, 10`, at `50%` would return `5`, whereas Anton's would return either `0` or `10`. 
    
    This PR removes the 'new' version, and uses only the 'legacy' percentiles, also for the ResettingTimer type. 
    
    The resetting timer snapshot was also defined so that it would expose the internal values. This has been removed, and getters for `Max, Min, Mean` have been added instead. 
    
    ### Unexport types
    
    A lot of types were exported, but do not need to be. This PR unexports quite a lot of them.
    holiman authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8b6cf12 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eb74389 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. eth: abort on api operations not available in pbss-mode (#28104)

    eth: abort on api calls not supporting pbss
    s1na authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    b9b99a1 View commit details
    Browse the repository at this point in the history
  2. cmd/geth, internal/flags, go.mod: colorize cli help, support env vars…

    … (#28103)
    
    * cmd/geth, internal/flags, go.mod: colorize cli help, support env vars
    
    * internal/flags: use stdout, not stderr for terminal detection
    karalabe authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    d9fbb71 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    636c64c View commit details
    Browse the repository at this point in the history
  4. internal/flags: fix linter

    karalabe committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    86bc2cd View commit details
    Browse the repository at this point in the history
  5. graphql: add 4844 blob fields (#27963)

    This adds block and receipt fields for EIP-4844.
    
    ---------
    
    Signed-off-by: jsvisa <[email protected]>
    Co-authored-by: Sina Mahmoodi <[email protected]>
    jsvisa and s1na authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    8514d66 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ee65462 View commit details
    Browse the repository at this point in the history
  7. rlp/rlpgen: remove build tag (#28106)

    * rlp/rlpgen: remove build tag
    
    This tag was supposed to prevent unstable output when types reference each other. Imagine
    there are two struct types A and B, where a reference to type B is in A. If I run rlpgen
    on type B first, and then on type A, the generator will see the B.EncodeRLP method and
    call it. However, if I run rlpgen on type A first, it will inline the encoding of B.
    
    The solution I chose for the initial release of rlpgen was to just ignore methods
    generated by rlpgen using a build tag. But there is a problem with this: if any code in
    the package calls EncodeRLP explicitly, the package can't be loaded without errors anymore
    in rlpgen, because the loader ignores it. Would be nice if there was a way to just make it
    ignore invalid functions during type checking (they're not necessary for rlpgen), but
    golang.org/x/tools/go/packages does not provide a way of ignoring them.
    
    Luckily, the types we use rlpgen with do not reference each other right now, so we can
    just remove the build tags for now.
    fjl authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    909dd4a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    65a17c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. core/state: check err for iter.Error in fastDeleteStorage (#28122)

    core/state: check err for iter.Error
    darioush authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    48fdb79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4fa3db4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    16cd1a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Configuration menu
    Copy the full SHA
    9a9db3d View commit details
    Browse the repository at this point in the history
  2. internal/ethapi: correctly calculate effective gas price (#28130)

    correctly calculate effective gas price
    cam-schultz authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    2177193 View commit details
    Browse the repository at this point in the history
  3. internal/flags: fix typo (#28133)

    fix(flag): one typo
    phenix3443 authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    52234eb View commit details
    Browse the repository at this point in the history
  4. params: fix typo in comment (#28129)

    fix: typo
    phenix3443 authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    d8a351b View commit details
    Browse the repository at this point in the history
  5. core, eth/downloader: fix genesis state missing due to state sync (#2…

    …8124)
    
    * core: fix chain repair corner case in path-based scheme
    
    * eth/downloader: disable trie database whenever state sync is launched
    rjl493456442 authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    c53b0fe View commit details
    Browse the repository at this point in the history
  6. params: release Geth v1.13.1

    karalabe committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    3f40e65 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    90d5bd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. cmd/evm: fix some issues with the evm run command (#28109)

    * cmd/evm: improve flags handling
    
    This fixes some issues with flags in cmd/evm. The supported flags did not
    actually show up in help output because they weren't categorized. I'm also
    adding the VM-related flags to the run command here so they can be given
    after the subcommand name. So it can be run like this now:
    
       ./evm run --code 6001 --debug
    
    * cmd/evm: enable all forks by default in run command
    
    The default genesis was just empty with no forks at all, which is annoying because
    contracts will be relying on opcodes introduced in a fork. So this changes the default to
    have all forks enabled.
    
    * core/asm: fix some issues in the assembler
    
    This fixes minor bugs in the old assembler:
    
    - It is now possible to have comments on the same line as an instruction.
    - Errors for invalid numbers in the jump instruction are reported better
    - Line numbers in errors were off by one
    fjl authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e9f78db View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef76afa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4b748b7 View commit details
    Browse the repository at this point in the history
  4. cmd/devp2p: use bootnodes as crawl input (#28139)

    This PR makes the tool use the --bootnodes list as the input to devp2p crawl.
    The flag will take effect if the input/output.json file is missing or empty.
    jsvisa authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    41a0ad9 View commit details
    Browse the repository at this point in the history
  5. go.mod: use existing version of karalabe/usb (#28127)

    There is no 0.0.3 release of karalabe/usb.
    holiman authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    30d5d7c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7ed5bc0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5c6f4b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. cmd/clef: suppress fsnotify error if keydir not exists (#28160)

    As the keydir will be automatically created after an account is created, no error message if the watcher is failed.
    jsvisa authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5b9cbe3 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. core/rawdb: no need to run truncateFile for readonly mode (#28145)

    Avoid truncating files, if ancients are opened in readonly mode. With this change, we return error instead of trying (and failing)  to repair
    jsvisa authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    545f4c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. trie: remove internal nodes between shortNode and child in path mode …

    …(#28163)
    
    * trie: remove internal nodes between shortNode and child in path mode
    
    * trie: address comments
    
    * core/rawdb, trie: address comments
    
    * core/rawdb: delete unused func
    
    * trie: change comments
    
    * trie: add missing tests
    
    * trie: fix lint
    rjl493456442 authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4773dcb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03c2176 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    83f3fc2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d135baf View commit details
    Browse the repository at this point in the history
  5. core/rawdb: use readonly file lock in readonly mode (#28180)

    This allows using the freezer from multiple processes at once
    in read-only mode.
    
    Co-authored-by: Martin Holst Swende <[email protected]>
    jsvisa and holiman authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f1b2ec0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    82ec555 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    323542a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d051ea5 View commit details
    Browse the repository at this point in the history
  3. core/bloombits: fix deadlock when matcher session hits an error (#28184)

    When MatcherSession encounters an error, it attempts to close the session.
    Closing waits for all goroutines to finish, including the 'distributor'. However, the
    distributor will not exit until all requests have returned.
    
    This patch fixes the issue by delivering the (empty) result to the distributor
    before calling Close().
    msmania authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c2cfe35 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1fa3362 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c3742a9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3d297fc View commit details
    Browse the repository at this point in the history
  7. cmd/utils: fix bootnodes config priority (#28095)

    This fixes an issue where the --bootnodes flag was overridden by the config file.
    
    ---------
    
    Co-authored-by: NathanBSC <[email protected]>
    Co-authored-by: Felix Lange <[email protected]>
    3 people authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f6f64cc View commit details
    Browse the repository at this point in the history
  8. ethclient: fix BlockReceipts parameter encoding (#28087)

    Co-authored-by: Felix Lange <[email protected]>
    kandrianov and fjl authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    4985d83 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. core/vm: minor code formatting (#28199)

    Adding a space beween function opOrigin() and opcCaller() in instruciton.go.
    Adding a space beween function opkeccak256()  and opAddress() in instruciton.go.
    hzysvilla authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4de89e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4021910 View commit details
    Browse the repository at this point in the history
  3. eth/fetcher: allow underpriced transactions in after timeout (#28097)

    This PR will allow a previously underpriced transaction back in after a timeout
    of 5 minutes. This will block most transaction spam but allow for transactions to
    be re-broadcasted on networks with less transaction flow.
    
    ---------
    
    Co-authored-by: Felix Lange <[email protected]>
    MariusVanDerWijden and fjl authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    2b7bc2c View commit details
    Browse the repository at this point in the history
  4. internal/ethapi: eth_call block parameter is optional (#28165)

    So apparently in the spec the base block parameter of eth_call is optional.
    I agree that "latest" is a sane default for this that most people would use.
    s1na authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    adb9b31 View commit details
    Browse the repository at this point in the history
  5. eth/downloader: remove header rollback mechanism (#28147)

    * eth/downloader: remove rollback mechanism in downloader
    
    * eth/downloader: remove the tests
    rjl493456442 authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b85c183 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. core/txpool: fix typos (#28208)

    core/txpool:fix typos
    bnovil authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    614804b View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. core/txpool: fix typos (#28213)

    fix(core/txpool): fix typos
    0xbstn authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a081130 View commit details
    Browse the repository at this point in the history
  2. core, accounts, eth, trie: handle genesis state missing (#28171)

    * core, accounts, eth, trie: handle genesis state missing
    
    * core, eth, trie: polish
    
    * core: manage txpool subscription in mainpool
    
    * eth/backend: fix test
    
    * cmd, eth: fix test
    
    * core/rawdb, trie/triedb/pathdb: address comments
    
    * eth, trie: address comments
    
    * eth: inline the function
    
    * eth: use synced flag
    
    * core/txpool: revert changes in txpool
    
    * core, eth, trie: rename functions
    rjl493456442 authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    73f5bcb View commit details
    Browse the repository at this point in the history
  3. params: release Geth v1.13.2

    karalabe committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    dc34fe8 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    e8bcd80 View commit details
    Browse the repository at this point in the history
  2. add formatting script

    darioush committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    47e02bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0234af5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e63b792 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    38b66f8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    38ac6b3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    63b5c2a View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Configuration menu
    Copy the full SHA
    13d4691 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. uts passing

    darioush committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    f50fae9 View commit details
    Browse the repository at this point in the history
  2. fix allowed imports

    darioush committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    cdf5ee1 View commit details
    Browse the repository at this point in the history
  3. fix txpool close

    darioush committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    db44d2b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    631a82f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    eeafb2d View commit details
    Browse the repository at this point in the history
  6. Revert "format: remove avalanche header"

    This reverts commit e63b792.
    darioush committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    92f4c11 View commit details
    Browse the repository at this point in the history
  7. format: add avalanche header

    darioush committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    58542e7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    072652b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c20a58a View commit details
    Browse the repository at this point in the history
  10. fix mockgen

    darioush committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    609f7b4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9b5259f View commit details
    Browse the repository at this point in the history
  12. linting

    darioush committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    1e72bac View commit details
    Browse the repository at this point in the history
  13. fix sync argument

    darioush committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    2595549 View commit details
    Browse the repository at this point in the history
  14. shell-check

    darioush committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    3252162 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. move reorg feed notification

    darioush committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    5bf7a9d View commit details
    Browse the repository at this point in the history
  2. fix go:generate comments

    darioush committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    d08dfe2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    53ca9f9 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. nit: update comment

    darioush committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    aced8af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4a770e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a02f299 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5b16e4d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    349bb30 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5087070 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3ed22f9 View commit details
    Browse the repository at this point in the history
  8. fix gen comment

    darioush committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    9ba495d View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Geth v1.12.2 nits (#1099)

    * use upstream cmd/utils
    
    * format nits
    
    * accessor chain format nits
    
    * move chain config func to extra file
    
    * rename AvalancheRules to Rules
    
    * add transitive deps
    
    * remove unnecessary type checks
    
    * remove extra lock
    
    * remove last seen
    
    * format: remove avalanche header
    
    * format: add upstream go-ethereum
    
    * prepare repo for upstream
    
    * more cosmetic changes to reduce diff
    
    * Revert "format: remove avalanche header"
    
    This reverts commit ea6f31d.
    
    * Revert "format: add upstream go-ethereum"
    
    This reverts commit 0fdf3e8.
    
    * Revert "prepare repo for upstream"
    
    This reverts commit ffe9024.
    
    * fix func name
    
    * readd type checks
    
    * allow cmd/utils from upstream
    
    * fix linter
    
    * Revert "use upstream cmd/utils"
    
    This reverts commit 52e2adf.
    
    * Revert "allow cmd/utils from upstream"
    
    This reverts commit 8ed4cb8.
    
    * split flags file
    
    * run UT with race
    
    * remove unneccessary const
    ceyonur authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7c77dff View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    23dfdc4 View commit details
    Browse the repository at this point in the history
  2. IteratePending returns bool

    darioush committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    6d354d6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a5b6bb5 View commit details
    Browse the repository at this point in the history
  4. remove unused RemoveTx

    darioush committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    4969682 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c67b0fb View commit details
    Browse the repository at this point in the history
  6. cmd, core, eth, graphql, trie: no persisted clean trie cache file (#2…

    …7525)
    
    The clean trie cache is persisted periodically, therefore Geth can
    quickly warmup the cache in next restart.
    
    However it will reduce the robustness of system. The assumption is
    held in Geth that if the parent trie node is present, then the entire
    sub-trie associated with the parent are all prensent.
    
    Imagine the scenario that Geth rewinds itself to a past block and
    restart, but Geth finds the root node of "future state" in clean
    cache then regard this state is present in disk, while is not in fact.
    
    Another example is offline pruning tool. Whenever an offline pruning
    is performed, the clean cache file has to be removed to aviod hitting
    the root node of "deleted states" in clean cache.
    
    All in all, compare with the minor performance gain, system robustness
    is something we care more.
    rjl493456442 authored and darioush committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    83f28ef View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7e8c6a3 View commit details
    Browse the repository at this point in the history
  8. lint: dead code

    darioush committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d4c07fb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    45d3b34 View commit details
    Browse the repository at this point in the history
  10. left out of prev. change

    darioush committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    4396703 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    24cc02a View commit details
    Browse the repository at this point in the history
  2. merge fixes

    darioush committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    ec95970 View commit details
    Browse the repository at this point in the history
  3. compile compatible coreth

    darioush committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    bd2f96e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    217b78c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ecbcbb6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a4e07eb View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    d1f02c7 View commit details
    Browse the repository at this point in the history
  2. fix test

    darioush committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    24163e3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3624b90 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c92eeb2 View commit details
    Browse the repository at this point in the history
  5. Revert "format: remove avalanche header"

    This reverts commit 217b78c.
    darioush committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c6640ac View commit details
    Browse the repository at this point in the history
  6. fix rlpgen comments

    darioush committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    95f0e15 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    80fdc34 View commit details
    Browse the repository at this point in the history
  8. unused files

    darioush committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9b482e6 View commit details
    Browse the repository at this point in the history
  9. lint

    darioush committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    a2a2b35 View commit details
    Browse the repository at this point in the history
  10. resolve some of the TODOS

    darioush committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e44d623 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. remove chaininfo metric

    darioush committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f38bab8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    52952b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. deprecate tx-lookup-limit

    darioush committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    95120b7 View commit details
    Browse the repository at this point in the history
  2. fix testDeleteStorage

    darioush committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    1c2e8f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8c0c7bd View commit details
    Browse the repository at this point in the history
  4. fix race

    darioush committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2e2beea View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    4af41a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cadd7bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1283cb0 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. fix coreth versioning

    darioush committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    02377fb View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. add log formats from upstream (#1140)

    * add log formats from upstream
    
    * remove align
    ceyonur authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    4bdba28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3baeec View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. add comment

    darioush committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    eb9d16a View commit details
    Browse the repository at this point in the history