docs(libevm/tooling/release): add readme #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
requested changes
Mar 26, 2025
| The `myusername/release/v1.13.14-0.2.0.rc.4` branch will be used to add "release modifications" and will target the branch `release/v1.13.14-0.2.0.rc.4` in a pull request. | ||
| 1. Run script `./cherrypick.sh` which cherry picks all Geth commits listed in [cherrypicks](cherrypicks) | ||
| - you may have to resolve conflicts | ||
| 1. Modify [params/version.libevm.go](/params/version.libevm.go) |
There was a problem hiding this comment.
It's useful to have this as the first step but NOT have anything committed. That way the version string is automatically generated for naming the release branch.
There was a problem hiding this comment.
That way the version string is automatically generated for naming the release branch.
Through a test right?
I think it's best to keep it as it is, and have the CI check on the version string humanly typed, to avoid any bad copy-paste surprises.
Co-authored-by: Arran Schlosberg <[email protected]> Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]> Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]> Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]> Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]> Signed-off-by: Quentin McGaw <[email protected]>
qdm12
commented
Mar 28, 2025
|
|
||
| ```bash | ||
| VERSION=v1.13.14-0.2.0.rc.4 | ||
| USERNAME=myusername |
There was a problem hiding this comment.
Change to GH_USER or it conflicts with OSX $USERNAME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The documentation was lacking on how to create a new release tag, using newer automation tools developed.
How this works
Add readme.md in libevm/tooling/release and reference it in the root readme.md
How this was tested
Following each step to create https://github.com/ava-labs/libevm/releases/tag/v1.13.14-0.2.0.rc.4