General Ginkgo E2E test framework + Teleporter test cases #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam,
gwen917,
geoff-vball,
bernard-avalabs and
feuGeneA
as code owners
bernard-avalabs
previously approved these changes
Nov 27, 2023
michaelkaplan13
previously approved these changes
Nov 27, 2023
There was a problem hiding this comment.
LGTM!
A handful of the outstanding TODOs should be taken care of in #132 once I'm able to update it with the latest changes from here.
geoff-vball
previously approved these changes
Nov 27, 2023
minghinmatthewlam
previously approved these changes
Nov 27, 2023
gwen917
dismissed stale reviews from minghinmatthewlam, geoff-vball, and michaelkaplan13
via
9e9ccd0
geoff-vball
previously approved these changes
Nov 27, 2023
gwen917
requested review from
feuGeneA,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
minghinmatthewlam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The E2E tests currently spin up a local network and run the tests in a Ginkgo container environment. This PR adds the ability to run the same E2E tests against any network, such as a set of subnets deployed on Fuji.
This PR also serves as a dev branch for the test cases implemented in the PRs listed in #94. Once all of those test cases are implemented and merged here, this PR will be eligible to merge to main.
How this works
Adds a
Networkinterface that may be implemented to point to any network. Adds a layer of indirection in the Ginkgo E2E entrypoint to inject the local network implementation. A Fuji implementation may similarly be provided.How this was tested
E2E tests, CI. Successfully ran E2E tests against live Fuji subnets.
How is this documented
Added a README section describing how to implement and use
Networkto generalize the E2E tests.