Add getters to validator manager #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
getters-validator-manager
branch
from
3337c61 to
e7103d2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
geoff-vball
force-pushed
the
getters-validator-manager
branch
from
4abacde to
bf2ffcc
Compare
geoff-vball
commented
Nov 29, 2024
Comment on lines
-472
to
-479
| /** | ||
| * @notice Returns the validator's weight. This weight is not guaranteed to be known by the P-Chain | ||
| * @return Weight of the validator. If the validation ID does not exist, the weight will be 0. | ||
| */ | ||
| function getWeight(bytes32 validationID) external view returns (uint64) { | ||
| return getValidator(validationID).weight; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is redundant, we have an external getter for the Validator object
geoff-vball
force-pushed
the
getters-validator-manager
branch
from
a407a7f to
d46a4da
Compare
geoff-vball
requested review from
iansuvak,
richardpringle,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
richardpringle
approved these changes
Nov 29, 2024
bernard-avalabs
approved these changes
Dec 2, 2024
bernard-avalabs
approved these changes
Dec 4, 2024
…ontracts into getters-validator-manager
bernard-avalabs
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #645
Makes storage getters internal. This isn't the best coding practice, but contract code-size limits made this the most practical option. Child contracts should probably never write to their parent's storage.
How is this documented
N/A