Unit test coverage #624
Merged
Unit test coverage #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
requested review from
iansuvak,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
contracts/validator-manager/tests/ERC20TokenStakingManagerTests.t.sol
Outdated
Show resolved
Hide resolved
contracts/validator-manager/tests/PoSValidatorManagerTests.t.sol
Outdated
Show resolved
Hide resolved
richardpringle
approved these changes
Nov 21, 2024
iansuvak
reviewed
Nov 21, 2024
| ); | ||
| } | ||
|
|
||
| function testRegisterSubnetValidatorMessageInvalidInputLength() public { |
There was a problem hiding this comment.
Should we change the name here? It looks like this test checks 3 different invalid cases and not just InvalidInputLength
There was a problem hiding this comment.
Yeah I think the two tests below got copied into this test accidentally on a merge. All fixed now.
| } | ||
|
|
||
| function testRegisterSubnetValidatorMessageInvalidCodecID() public { | ||
| (, bytes memory packed) = ValidatorMessages.packRegisterL1ValidatorMessage( |
There was a problem hiding this comment.
Do this test case and testRegisterSubnetValidatorMessageInvalidTypeID below re-test functionality tested above? I agree that it would make sense to remove it from the above in that case to have a single test for single error state but we should be able to use _getPackedRegisterL1ValidatorMessage() as well
iansuvak
approved these changes
Nov 22, 2024
iansuvak
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Provides full coverage for all Validator Manager contracts except
ValidatorManager.sol(WIP).There are a couple checks that are currently unreachable, but I think are still good to have for when code changes.
Covecov doesn't seem to be able to handle one of the
if, elif, elsestatements.How this was tested
How is this documented
N/A