Staking contract E2E test setup #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
commented
Aug 15, 2024
tests/utils/teleporter_utils.go
Outdated
There was a problem hiding this comment.
No changes of substance in this file.
cam-schultz
commented
Aug 15, 2024
tests/utils/chain_utils.go
Outdated
There was a problem hiding this comment.
No changes of substance in this file.
cam-schultz
commented
Aug 15, 2024
tests/utils/erc20_utils.go
Outdated
There was a problem hiding this comment.
No changes of substance in this file.
cam-schultz
commented
Aug 15, 2024
tests/utils/governance_utils.go
Outdated
There was a problem hiding this comment.
No changes of substance in this file.
cam-schultz
requested review from
iansuvak,
feuGeneA,
geoff-vball,
minghinmatthewlam,
bernard-avalabs and
michaelkaplan13
geoff-vball
reviewed
Aug 16, 2024
geoff-vball
approved these changes
Aug 19, 2024
| // the P-Chain will reject the registration, and the stake can be returned to the staker after the registration | ||
| // expiry has passed. | ||
| require(signature.length == 64, "StakingManager: Invalid signature length"); | ||
| require(blsPublicKey.length == 48, "StakingManager: Invalid blsPublicKey length"); |
There was a problem hiding this comment.
can have a constant for the length
There was a problem hiding this comment.
Since these packing/unpacking methods are likely to be refactored/optimized significantly in the future, I'm going to hold off on making further changes for now. Also pointing out that there were no length constants in the previous implementation.
Co-authored-by: minghinmatthewlam <[email protected]> Signed-off-by: cam-schultz <[email protected]>
Co-authored-by: minghinmatthewlam <[email protected]> Signed-off-by: cam-schultz <[email protected]>
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes #433
Fixes #434
Fixes #470
Fixes #493
Supercedes #479
Demonstrates how to write E2E tests for the staking contracts
How this works
awm-relayerandavalanchegobranches with up-to-date ACP-118 and ACP-77 implementationstests/utilsinto multiple more focused files. The only relevant code changes here are instaking_utils.goHow this was tested
Added E2E test for registering and delisting a validator. Additional E2E tests to follow.
How is this documented
N/A