E2E flaky test fix #462
Merged
E2E flaky test fix #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
gstuart/test-fix-2
branch
from
60b67d5 to
e25618b
Compare
geoff-vball
force-pushed
the
gstuart/test-fix-2
branch
from
e13a05b to
81705aa
Compare
geoff-vball
force-pushed
the
gstuart/test-fix-2
branch
from
81705aa to
efe0554
Compare
geoff-vball
requested review from
iansuvak,
feuGeneA,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
iansuvak
previously approved these changes
Jul 31, 2024
cam-schultz
reviewed
Jul 31, 2024
tests/local/network.go
Outdated
| @@ -464,7 +471,7 @@ func (n *LocalNetwork) AddSubnetValidators(ctx context.Context, subnetID ids.ID, | |||
|
|
|||
| // consume some of the extraNodes | |||
| newValidatorNodes := n.extraNodes[0:count] | |||
| defer slices.Delete(n.extraNodes, 0, int(count)) | |||
| copy(n.extraNodes, n.extraNodes[count:]) | |||
There was a problem hiding this comment.
This will still preserve the nodes to be deleted in n.extraNodes, since n.extraNodes[count:] is a subset. See example here: https://go.dev/play/p/z8RhPp136sr
There was a problem hiding this comment.
Fixed by copying the newValidatorNodes from extraNodes and then just assigning extraNodes to the subset.
cam-schultz
reviewed
Jul 31, 2024
| @@ -470,8 +470,9 @@ func (n *LocalNetwork) AddSubnetValidators(ctx context.Context, subnetID ids.ID, | |||
| )] | |||
|
|
|||
| // consume some of the extraNodes | |||
| newValidatorNodes := n.extraNodes[0:count] | |||
| copy(n.extraNodes, n.extraNodes[count:]) | |||
| var newValidatorNodes []*tmpnet.Node | |||
There was a problem hiding this comment.
Suggested change
| var newValidatorNodes []*tmpnet.Node | |
| newValidatorNodes := make([]*tmpnet.Node, len(n.extraNodes[0:count])) |
We need to preallocate the destination, otherwise nothing will be copied. Example
There was a problem hiding this comment.
The append approach you adopted also works.
cam-schultz
approved these changes
Jul 31, 2024
michaelkaplan13
approved these changes
Jul 31, 2024
iansuvak
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes test flakiness introduced with the switchover to tmpnet.
Also contains some formatting
How this works
Sorts the slice created by
GetSubnetsInfo()before returning it. We were adding items to a slice by ranging over a map, which gives a random order. Therefore callingGetTwoSubnets()could return the two subnets in the opposite order if called twice in one test.How this was tested
Existing E2E tests.
How is this documented
N/A