-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to tmpnet & latest subnetevm #401
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
a611a72
DRAFT
feuGeneA ff521f8
inline call to `GetAllNodeIDs()`
feuGeneA eb248d9
clarify chain config map util abstraction
feuGeneA 6ede518
bump up and unify timeout values
feuGeneA 32f349e
instantiate subnet genesis from template w/chainID
feuGeneA f5a7411
stop appending funded key to tmpnet's array
feuGeneA 1e4e260
document `extraNodes`
feuGeneA 9b690bd
stop filtering out chains that aren't even there
feuGeneA 850c0d5
parameterize subnet specification
feuGeneA bf37499
NewLocalNetwork: parameterize network name
feuGeneA eab5471
NewLocalNetwork: parameterize extra node count
feuGeneA ef2dc26
Merge remote-tracking branch 'origin/main' into tmpnet
feuGeneA 956420b
inform test user of tmpnet dir
feuGeneA 87c644b
Apply suggestions from code review
feuGeneA 6f79016
setSubnetValues(): accept a Subnet, not a SubnetID
feuGeneA bc9b1b6
genesis template: ReadFile; close output file
feuGeneA 809427d
Merge branch 'main' into tmpnet
feuGeneA 8b61fba
Merge branch 'main' into tmpnet
geoff-vball ddbbfb1
adapt to my merged avalanchego changes
feuGeneA 51c0c0d
use latest commits of avalanchego & subnet-evm
feuGeneA 8cc205d
Merge branch 'main' into tmpnet
feuGeneA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does uploading this artifact do? Is it to restart the tmpnet on a different machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the prometheus stuff I just copied along with the rest of it from avalanchego 😅 but the
~/.tmpnet/networkspart is the most pertinent: that folder contains all of the logs, configs, etc for the network and all the nodes started for it. tmpnet chooses not to dump all of those logs to stdout, instead putting them on disk in that folder (a different sub-folder per tmpnet run). uploading that folder allows us to see the full diagnostic info for a test run, since it's not all included in the direct output of the CI job.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... Would it make sense to tail the log file with a goroutine so the test suite outputs to stdout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe? this environment is currently spinning up 15 nodes, so it'd be tailing 15 different log files, which would be a lot of output. I guess it's no more than before, but Maru told me that the tmpnet philosophy is to dump log files to disk rather than flood stdout.
as an alternative, I used ginkgo's
AddReportEntryfunction to inform the user of the directory where the the node logs can be found, in 956420b. what do you think of that?