Refactor fee info v2 #146
Merged
Refactor fee info v2 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
martineckardt
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
gwen917,
geoff-vball and
bernard-avalabs
as code owners
michaelkaplan13
approved these changes
Nov 20, 2023
geoff-vball
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Make fee info more intuitive by renaming
contractAddresstofeeTokenAddressinfeeInfoHow this works
contractAddresstofeeTokenAddressin TeleporterMessenger and all cross-chain-application that are utilizing itHow this was tested
Ran 23 test suites: 138 tests passed, 0 failed, 0 skipped (138 total tests)How is this documented
Updated references to feeInfo in READMEs