Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC20 bridge multihop #140

Merged
merged 13 commits into from
Nov 21, 2023
Merged

ERC20 bridge multihop #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
51a1a5e
ERC20 bridge multihop
gwen917 Nov 16, 2023
9dd9266
Merge remote-tracking branch 'origin/general-e2e' into erc20-bridge-m…
gwen917 Nov 16, 2023
81c40de
fix
gwen917 Nov 16, 2023
4632158
fix lint
gwen917 Nov 16, 2023
dfde758
fix lint
gwen917 Nov 16, 2023
e0cae29
fix
gwen917 Nov 17, 2023
4c76abc
fix
gwen917 Nov 17, 2023
8d12650
fix
gwen917 Nov 17, 2023
460f295
fix
gwen917 Nov 17, 2023
06c42ed
fix validator for subnetC
gwen917 Nov 20, 2023
9342e1f
run ValidatorChurn in the end
gwen917 Nov 20, 2023
7298c4a
Merge remote-tracking branch 'origin/general-e2e' into erc20-bridge-m…
gwen917 Nov 21, 2023
3ea5c66
fix
gwen917 Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ var _ = ginkgo.BeforeSuite(func() {
var _ = ginkgo.AfterSuite(localUtils.TearDownNetwork)

var _ = ginkgo.Describe("[Teleporter integration tests]", func() {
// Cross-chain application tests
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the comment below, and we issue tx to propose vm to all subnets, I'd like for validator churn to not need to be added last. Do you know right now if these tests are in random order?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. If we can fix it we should. Otherwise what happens if we have another test that also needs to go last? 🙃

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of making the issue to proposevm calls to each subnet individually, can we iterate through all subnets in the network, get subnet info, and issue tx? To prevent in the future if we add more subnets for this test to break and need to be debugged.

ginkgo.It("Example cross chain messenger", ExampleMessengerGinkgo)
ginkgo.It("ERC20 bridge multihop", ERC20BridgeMultihopGinkgo)

// Teleporter tests
ginkgo.It("Send a message from Subnet A to Subnet B", BasicOneWaySendGinkgo)
ginkgo.It("Deliver to the wrong chain", DeliverToWrongChainGinkgo)
Expand All @@ -63,7 +67,7 @@ var _ = ginkgo.Describe("[Teleporter integration tests]", func() {
ginkgo.It("Resubmit altered message", ResubmitAlteredMessageGinkgo)
ginkgo.It("Relayer modifies message", RelayerModifiesMessageGinkgo)
ginkgo.It("Validator churn", ValidatorChurnGinkgo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here explaining that this test should be run last since it changes the network topology? In theory it shouldn't have any effect, but it seems like we have some further investigating to do. Can you please create a ticket and include all of your findings so far?

gwen917 marked this conversation as resolved.
Show resolved Hide resolved

// Cross-chain application tests
ginkgo.It("Example cross chain messenger", ExampleMessengerGinkgo)
// Since the validator churn test modifies the network topology, we put it last for now.
// It should not affect the other tests, but we get some errors if we run it before the other tests.
// TODO: we should fix this so that the order of the tests does not matter.
})
Loading
Loading