Apply suggestions from code review

Co-authored-by: Michael Kaplan <[email protected]>
Signed-off-by: F. Eugene Aumson <[email protected]>

tests/flows/teleporter_registry.go

@@ -75,9 +75,8 @@ func TeleporterRegistry(network interfaces.LocalNetwork) {
 	chainConfigs.Add(subnetAInfo, warpEnabledChainConfigA)
 
 	// Restart nodes with new chain config
-	nodeIDs := network.GetAllNodeIDs()
 	network.SetChainConfigs(chainConfigs)
-	network.RestartNodes(ctx, nodeIDs)
+	network.RestartNodes(ctx, network.GetAllNodeIDs())
 
 	// Call addProtocolVersion on subnetB to register the new Teleporter version
 	utils.AddProtocolVersionAndWaitForAcceptance(

tests/local/network.go

@@ -81,7 +81,7 @@ func NewLocalNetwork(
 	ctx := context.Background()
 	var err error
 
-	// declare some extra nodes to be used to add more validators later:
+	// Create extra nodes to be used to add more validators later
 	extraNodes := subnetEvmTestUtils.NewTmpnetNodes(extraNodeCount)
 
 	f, err := os.CreateTemp(os.TempDir(), "config.json")
@@ -537,7 +537,7 @@ func (n *LocalNetwork) RestartNodes(ctx context.Context, nodeIDs []ids.NodeID) {
 }
 
 func (n *LocalNetwork) SetChainConfigs(chainConfigs map[string]string) {
-	for chainIdStr, chainConfig := range chainConfigs {
+	for chainIDStr, chainConfig := range chainConfigs {
 		if chainIdStr == utils.CChainPathSpecifier {
 			var cfg tmpnet.FlagsMap
 			err := json.Unmarshal([]byte(chainConfig), &cfg)

tests/utils/utils.go

@@ -1205,8 +1205,7 @@ func InstantiateGenesisTemplate(
 
 	scanner := bufio.NewScanner(templateFile)
 	for scanner.Scan() {
-		var replaced string
-		replaced = scanner.Text()
+		replaced := scanner.Text()
 		for _, s := range substitutions {
 			replaced = strings.Replace(replaced, s.Target, s.Value, 1)
 		}