Snow VM #1831
Snow VM #1831
Conversation
aaronbuchwald
added
the
DO NOT MERGE
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Next steps:
Most importantly break this PR up |
| res.Errors = make([]string, len(errs)) | ||
| for i, err := range errs { | ||
| if err != nil { | ||
| res.Errors[i] = err.Error() | ||
| } |
There was a problem hiding this comment.
Fixes a bug discovered in a newly added test. If the error was nil, then the previous code triggered a panic.
| return fmt.Errorf("%w: tx timestamp (%d) < block timestamp (%d)", ErrTimestampTooLate, b.Timestamp, timestamp) | ||
| case b.Timestamp > timestamp+r.GetValidityWindow(): // tx: 100 block 10 | ||
| return ErrTimestampTooEarly | ||
| return fmt.Errorf("%w: tx timestamp (%d) > block timestamp (%d) + validity window (%d)", ErrTimestampTooEarly, b.Timestamp, timestamp, r.GetValidityWindow()) |
There was a problem hiding this comment.
Added details while debugging newly added tests. These errors are much more helpful with the added information.
| @@ -72,10 +71,8 @@ func (p *PreExecutor) PreExecute( | |||
| } | |||
|
|
|||
| // Verify auth if not already verified by caller | |||
| if verifyAuth { | |||
There was a problem hiding this comment.
This was never false previously.
| // NewTransaction creates a Transaction and initializes the private fields. | ||
| func NewTransaction(base *Base, actions Actions, auth Auth) (*Transaction, error) { |
There was a problem hiding this comment.
Need this exported for newly added tests
| authFactories := testingNetworkConfig.AuthFactories() | ||
| spamKey := authFactories[0] | ||
| generator := workload.NewTxGenerator(authFactories[1]) | ||
| tc := e2e.NewTestContext() | ||
| he2e.SetWorkload(testingNetworkConfig, generator, expectedABI, &spamHelper, firstAuthFactory) | ||
| he2e.SetWorkload(testingNetworkConfig, generator, expectedABI, &spamHelper, spamKey) |
There was a problem hiding this comment.
Throughput and workflow tests should not share the same pre-funded key
| type Ready interface { | ||
| IsReady() bool | ||
| } |
There was a problem hiding this comment.
Remove the need for IsReady and register the gossip handler when it's ready instead
| @@ -8,10 +8,10 @@ import ( | |||
| "testing" | |||
|
|
|||
| "github.com/ava-labs/avalanchego/ids" | |||
| "github.com/ava-labs/avalanchego/trace" | |||
There was a problem hiding this comment.
remove need for HyperSDK defined trace package
| @@ -1,666 +0,0 @@ | |||
| // Copyright (C) 2024, Ava Labs, Inc. All rights reserved. | |||
There was a problem hiding this comment.
TODO: add integration testing harness for VMs and use for MorpheusVM
This refactor is intended to separate out maintenance of the AvalancheGo specific invariants and initialization from the VM package.
Prior to this PR, the VM package:
snowman.Block,block.ChainVM, andblock.StateSyncableVMinterfacesThis PR aims to reduce the responsibilities of the VM package as much as possible. Note: #1744 moved the
StatefulBlocktype out of the chain package and into VM. This continues to remove AvalancheGo specific functionality from the HyperVM specific components.The goal of this refactor is to get to a point where:
snowpackage implementssnowman.Blockandblock.ChainVMand maintains invariants required by consensus enginesnowpackage can be tested independently of HyperSDK chain logic that it correctly maintains those invariantssnowpackage "decomposes" the AvalancheGo VM interface into components with given defaults and can be overridden by an individual chain (currentlyOptions, but should be renamed as it doesn't quite fit under this pattern)vmpackage tohypervmvmpackage plays the role of initializing all of the required components and implementing a simpler interface that handles the required block state transitionsvmpackage that do not need to cover consensus engine edge caseschain.OutputBlockafter accept that can be sent to relevant APIs)