Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: account renaming via rpc #38

Merged
merged 9 commits into from
Sep 12, 2024
Merged

feat: account renaming via rpc #38

merged 9 commits into from
Sep 12, 2024

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Sep 4, 2024 •
edited
Loading

Description

Changes

  • Adds avalanche_renameAccount request handler
  • Migrates UI to use the new handler instead of ExtensionRequest.ACCOUNT_RENAME and removes the old handler
  • Maintenance: replaces isCoreWeb() with isSyncDomain(), as the latter also supports feature branch deploys of Core Web (e.g. develop.core-web.pages.dev)

Testing

  • Use playground to rename the account (see PR link above)
  • Rename account in the extension itself

Screenshots:

N/A

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

bferenc
bferenc requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@bferenc bferenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some questions below 👇

src/background/services/accounts/handlers/avalanche_renameAccount.ts Show resolved Hide resolved
src/background/services/accounts/handlers/avalanche_renameAccount.ts Outdated Show resolved Hide resolved
@meeh0w meeh0w requested a review from bferenc September 4, 2024 15:36
bferenc
bferenc previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@bferenc bferenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@meeh0w meeh0w force-pushed the feat/account-renaming-via-rpc branch from 7ca0d00 to 3e807e2 Compare September 9, 2024 08:38
@meeh0w meeh0w requested a review from bferenc September 9, 2024 08:38
@meeh0w
Copy link
Member Author

meeh0w commented Sep 9, 2024

@bferenc I had to resolve conflicts 🙏

@vvava
Copy link
Contributor

vvava commented Sep 12, 2024

Don't we want to accept account indexes as well? I mean not just account ids.

@meeh0w meeh0w merged commit 103f02f into main Sep 12, 2024
5 checks passed
@meeh0w meeh0w deleted the feat/account-renaming-via-rpc branch September 12, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bferenc bferenc bferenc approved these changes

@vvava vvava vvava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meeh0w @vvava @bferenc