Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: treat BTC as known network #37

Merged
merged 3 commits into from
Sep 2, 2024
Merged

fix: treat BTC as known network #37

merged 3 commits into from
Sep 2, 2024

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Aug 30, 2024 •
edited
Loading

Description

Changes

  • When network is already supported by the extension, do not use the request's payload, but rather resolve the network object via NetworkService and use that instead.

Testing

  1. Open extension, switch to C-Chain, go to Send
  2. Connect to Core Web
  3. Switch to Bitcoin via Core Web
  4. Open extension again, you should not see Unknown error

Screenshots:

Before

btc-werid-before.mov

After

btc-weird-after.mov

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@meeh0w
Copy link
Member Author

meeh0w commented Aug 30, 2024 •
edited
Loading

@gergelylovas thanks! Updated in c198a07.

vvava
vvava approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@vvava vvava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems working well 👍

@meeh0w meeh0w merged commit 8730f13 into main Sep 2, 2024
5 checks passed
@meeh0w meeh0w deleted the fix/btc-treated-as-custom-network branch September 2, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gergelylovas gergelylovas gergelylovas approved these changes

@vvava vvava vvava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meeh0w @gergelylovas @vvava