Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alt+shift+b shortcut #35

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: alt+shift+b shortcut #35

merged 1 commit into from
Aug 30, 2024

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Aug 30, 2024

Description

Gets rid of the error being reported every time extension boots up:

Screen.Recording.2024-08-30.at.11.33.34.mov

☝️ This should be no more. Also fixes Alt+Shift+B shortcut I never used ¯\_(ツ)_/¯

Changes

  • Updates manifest.json to use the proper command name: _execute_action instead of _execute_browser_action:

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@meeh0w meeh0w merged commit 0505dd9 into main Aug 30, 2024
4 of 5 checks passed
@meeh0w meeh0w deleted the fix/alt-shift-b branch August 30, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants