Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invisible no-thanks option #34

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: invisible no-thanks option #34

merged 1 commit into from
Aug 27, 2024

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Aug 27, 2024

Description

Testing

  • Go through onboarding with different wallet types, No Thanks option should always be visible on the analytics consent screen.

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@meeh0w meeh0w merged commit a089af6 into main Aug 27, 2024
5 checks passed
@meeh0w meeh0w deleted the fix/no-thanks-hidden branch August 27, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gergelylovas gergelylovas gergelylovas approved these changes

@bferenc bferenc bferenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meeh0w @gergelylovas @bferenc