[tmpnet] Enable runtime-specific restart behavior #3882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maru-ava
added
testing
4 tasks
maru-ava
force-pushed
the
tmpnet-final-refactor
branch
3 times, most recently
from
5b18b7a to
fd9bace
Compare
maru-ava
force-pushed
the
tmpnet-implicit-data-dir
branch
3 times, most recently
from
ca83ff8 to
465cd68
Compare
maru-ava
force-pushed
the
tmpnet-final-refactor
branch
2 times, most recently
from
b768168 to
bcf4146
Compare
maru-ava
force-pushed
the
tmpnet-implicit-data-dir
branch
from
465cd68 to
f0440ce
Compare
maru-ava
force-pushed
the
tmpnet-final-refactor
branch
from
bcf4146 to
11caceb
Compare
maru-ava
force-pushed
the
tmpnet-implicit-data-dir
branch
from
f0440ce to
1c1ab28
Compare
maru-ava
force-pushed
the
tmpnet-final-refactor
branch
from
11caceb to
3661417
Compare
maru-ava
force-pushed
the
tmpnet-implicit-data-dir
branch
from
1c1ab28 to
3b43707
Compare
maru-ava
force-pushed
the
tmpnet-final-refactor
branch
from
3661417 to
36f1837
Compare
maru-ava
force-pushed
the
tmpnet-final-refactor
branch
from
36f1837 to
fa68cad
Compare
maru-ava
force-pushed
the
tmpnet-final-refactor
branch
from
95041b1 to
db7e645
Compare
maru-ava
changed the title
maru-ava
changed the title
maru-ava
changed the title
maru-ava
force-pushed
the
tmpnet-final-refactor
branch
from
db7e645 to
59a0074
Compare
maru-ava
changed the title
maru-ava
changed the base branch from
tmpnet-flagsmap-string-values
to
tmpnet-move-monitoring-label-handling
There was a problem hiding this comment.
Pull Request Overview
This PR enables runtime-specific restart behavior for tmpnet by delegating restart responsibilities to the node runtime.
- Added a Restart method and corresponding saveAPIPort helper in ProcessRuntime to handle runtime-specific restart behavior.
- Updated the Node interface and implementation to wrap the ProcessRuntime.Restart method, and removed the standalone SaveAPIPort method.
- Refactored network restart logic by introducing the restartNodes helper and using WaitForHealthyNodes to ensure nodes are healthy after restart.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/fixture/tmpnet/process_runtime.go | Added Restart and saveAPIPort methods to implement runtime-specific restart logic. |
| tests/fixture/tmpnet/node.go | Added Restart method for Node that wraps ProcessRuntime.Restart and removed SaveAPIPort. |
| tests/fixture/tmpnet/network.go | Replaced RestartNode calls with the restartNodes helper and updated node restart flow. |
joshua-kim
approved these changes
Apr 18, 2025
maru-ava
force-pushed
the
tmpnet-move-monitoring-label-handling
branch
from
5ccfadb to
324a27a
Compare
Delegate responsibility for restart to the node runtime to allow the process runtime to continue to start/stop and the kube runtime to scale down/scale up.
maru-ava
force-pushed
the
tmpnet-final-refactor
branch
from
59a0074 to
74c3f11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Delegate responsibility for restart to the node runtime to allow the process runtime to continue to start/stop and the kube runtime to scale down/scale up.
How this was tested
CI
Need to be documented in RELEASES.md?
N/A
TODO