update generate staking files

node/add_validator_primary.go

@@ -5,6 +5,7 @@ package node
 
 import (
 	"fmt"
+	"github.com/ava-labs/avalanche-tooling-sdk-go/subnet"
 	"os"
 	"time"
 
@@ -23,6 +24,7 @@ import (
 )
 
 type PrimaryNetworkValidatorParams struct {
+	// NodeID is the unique identifier of the node to be added as a validator on the Primary Network.
 	NodeID ids.NodeID
 
 	Duration time.Duration
@@ -64,6 +66,12 @@ func (h *Node) ValidatePrimaryNetwork(
 	validator PrimaryNetworkValidatorParams,
 	wallet wallet.Wallet,
 ) (ids.ID, error) {
+	if validator.NodeID == ids.EmptyNodeID {
+		return ids.Empty, subnet.ErrEmptyValidatorNodeID
+	}
+	if validator.Duration == 0 {
+		return ids.Empty, subnet.ErrEmptyValidatorDuration
+	}
 	minValStake, err := GetMinStakingAmount(network)
 	if err != nil {
 		return ids.Empty, err

node/add_validator_primary_test.go

@@ -42,7 +42,7 @@ func TestNodesValidatePrimaryNetwork(_ *testing.T) {
 		Roles: []SupportedRole{Validator},
 	}
 
-	err = node.ProvideStakingCertAndKey(fmt.Sprintf("/Users/raymondsukanto/.avalanche-cli/nodes/%s", node.NodeID))
+	err = node.ProvideStakingFiles(fmt.Sprintf("/Users/raymondsukanto/.avalanche-cli/nodes/%s", node.NodeID))
 	if err != nil {
 		panic(err)
 	}

node/node.go

@@ -78,6 +78,9 @@ type Node struct {
 	// Logger for node
 	Logger avalanche.LeveledLogger
 
+	// BLS provides a way to aggregate signatures off chain into a single signature that can be efficiently verified on chain.
+	// To set BlsSecretKey of a node, use SetNodeBLSKey
+	// For more information about how BLS is used on the P-Chain, please head to https://docs.avax.network/cross-chain/avalanche-warp-messaging/deep-dive#bls-multi-signatures-with-public-key-aggregation
 	BlsSecretKey *bls.SecretKey
 }
 

node/staking.go

@@ -13,17 +13,25 @@ import (
 	"github.com/ava-labs/avalanchego/staking"
 )
 
-func (h *Node) ProvideStakingCertAndKey(keyPath string) error {
-	if nodeID, err := GenerateNodeCertAndKeys(keyPath); err != nil {
+// ProvideStakingFiles generates the files needed to validate the primary network:
+//   - staker.crt, staker.key, more information can be found at https://docs.avax.network/nodes/validate/how-to-stake#secret-management
+//   - The file containing the node's BLS information: signer.key (more information can be found at https://docs.avax.network/cross-chain/avalanche-warp-messaging/deep-dive#bls-multi-signatures-with-public-key-aggregation)
+//
+// and stores them in the provided directory in argument in local machine
+// and subsequently uploads these files into the remote host in /home/ubuntu/.avalanchego/staking/
+// directory
+func (h *Node) ProvideStakingFiles(keyPath string) error {
+	if nodeID, err := GenerateStakingFiles(keyPath); err != nil {
 		return err
 	} else {
 		h.Logger.Infof("Generated Staking Cert and Key for NodeID: %s in folder %s", nodeID.String(), keyPath)
 	}
 	return h.RunSSHUploadStakingFiles(keyPath)
 }
 
-// GenerateNodeCertAndKeys generates a node certificate and keys and return nodeID
-func GenerateNodeCertAndKeys(keyPath string) (ids.NodeID, error) {
+// GenerateStakingFiles generates the following files: staker.crt, staker.key and signer.key
+// and stores them in the provided directory in argument in local machine
+func GenerateStakingFiles(keyPath string) (ids.NodeID, error) {
 	if err := os.MkdirAll(keyPath, constants.DefaultPerms755); err != nil {
 		return ids.EmptyNodeID, err
 	}