This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
Remove default README and unnecessary TODO #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkaplan13
requested review from
cam-schultz,
minghinmatthewlam,
geoff-vball and
bernard-avalabs
as code owners
|
Just needs regenerated go bindings. Thanks for the cleanup :) |
| @@ -75,8 +75,6 @@ contract ERC20Destination is IERC20Bridge, TeleporterTokenDestination, ERC20 { | |||
| * @dev See {TeleportTokenDestination-_deposit} | |||
| */ | |||
| function _deposit(uint256 amount) internal virtual override returns (uint256) { | |||
| // TODO: can copy logic from SafeERC20TransferFrom.safeTransferFrom directly | |||
| // figure out if has gas savings. | |||
| return SafeERC20TransferFrom.safeTransferFrom(this, amount); | |||
There was a problem hiding this comment.
can you add a comment explaining this for internal library functions
There was a problem hiding this comment.
IMO a comment here is not necessary, otherwise we'd want to leave similar comments at every internal library call to remain consistent.
There was a problem hiding this comment.
yup agreed, ideally I'd want to add that comment in teleporter where the actual library code is, but thought this was easier. Not a big pref either way.
cam-schultz
approved these changes
Apr 4, 2024
minghinmatthewlam
approved these changes
Apr 4, 2024
geoff-vball
approved these changes
Apr 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Minor clean up
How this works
In Solidity, calls to internal library functions are automatically inlined, so there is no gas savings to copying the logic. From the Solidity docs:
How this was tested
N/A
How is this documented
N/A