This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Upgrading to OpenZeppelin v5 and Solidity 0.8.20 #196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minghinmatthewlam
requested review from
iansuvak,
feuGeneA,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
July 16, 2024 19:31
iansuvak
reviewed
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the typo, but looks like the e2e tests are still failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally makes sense to me. Just pointed a comment that might need to be updated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes #188
How this works
lib
instead of pointing the remapping toteleporter
'slib
SafeERC20.forceApprove
instead ofsafeApprove
IERC20Upgradeable
and instead upgradeable ERC20s still implementIERC20
WrappedNativeToken
does not need to be upgradeable._spendAllowance
is called, previous OZ v4 wouldemit Approval
, but in v5 by default it will not emit the event, so removed that emit from unit tests._burn
is moved above_handleFees
for token remotes, comparable to how token home contracts deposit then handle feesteleporter
upgraded versions commitHow this was tested
CI
How is this documented
update comments/readme