Improve change weight #2545
Merged
Improve change weight #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemadero
requested review from
sukantoraymond,
arturrez and
meaghanfitzgerald
|
Can be made in a separate PR but we should have test case for this in e2e |
arturrez
reviewed
Jan 10, 2025
sdk/validatormanager/helpers.go
Outdated
| @@ -0,0 +1,88 @@ | |||
| // Copyright (C) 2023, Ava Labs, Inc. All rights reserved. | |||
There was a problem hiding this comment.
I was looking into the similar thing and I think these functions should be not part of validatormanager sdk pkg, but new validator sdk as this pkg is about validatormanager smart contract
arturrez
reviewed
Jan 10, 2025
arturrez
reviewed
Jan 10, 2025
arturrez
reviewed
Jan 10, 2025
cmd/blockchaincmd/change_weight.go
Outdated
| } | ||
| var remainingBalanceOwnerAddr, disableOwnerAddr string | ||
| hrp := key.GetHRP(network.ID) | ||
| if len(vdrInfo.RemainingBalanceOwner.Addrs) > 0 { |
There was a problem hiding this comment.
should we check if vdrInfo.RemainingBalanceOwner is not nil to avoid possible crash
arturrez
reviewed
Jan 10, 2025
arturrez
reviewed
Jan 10, 2025
arturrez
reviewed
Jan 10, 2025
arturrez
reviewed
Jan 10, 2025
arturrez
reviewed
Jan 10, 2025
arturrez
approved these changes
Jan 14, 2025
|
ref: #2556 - create separate issue for Network model deprecation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
How is this documented