Add HyperSDK Functionality to CLI #2369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturrez
reviewed
Dec 18, 2024
| return err | ||
| } | ||
| switch option { | ||
| case providePath: |
There was a problem hiding this comment.
no need to add another prompt to ask for path. better UX is to just ask user to provide path to genesis right away and use it after checking if file exists. So this case branch is not needed here and can be moved up to How would you like to provide the genesis file? prompt
arturrez
reviewed
Dec 18, 2024
| return nil, nil | ||
| } | ||
|
|
||
| func getChainID(app *application.Avalanche) (ids.ID, error) { |
There was a problem hiding this comment.
nit: better name promptChainID
arturrez
reviewed
Dec 18, 2024
| return json.Marshal(genesis) | ||
| } | ||
|
|
||
| func getPreallocations(app *application.Avalanche) ([]*genesis.CustomAllocation, error) { |
There was a problem hiding this comment.
nit: better name promptPreallocations
|
looking into the code it's not clear for me what the difference between customVM and hypersdk VM option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
With the HyperSDK maturing, we would like to make it a first-class citizen (i.e. the same level of support as Subnet-EVM). By doing this, HyperSDK developers benefit from the following:
How this works
This PR separates HyperVMs (VMs built with HyperSDK) from the custom VM group and makes it a group of its own. Therefore, we now have three types of VMs in the CLI:
The biggest change is in the
avalanche blockchain createcommand, where users are now able to select the option of creating a HyperVM. When selecting this option, the control flow is similar to that of Subnet-EVM, with the exception of the genesis.In addition to being able to provide a
genesis.jsonfile and being able to use the default HyperSDK genesis, users can also use their VM binary to create the VM genesis on their behalf.How this was tested
How is this documented
We plan on adding documentation for this feature in the HyperSDK docs.
cc: @felipemadero @aaronbuchwald