-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/book: Typo in layers.html #98
base: master
Are you sure you want to change the base?
Conversation
Writer should have been intended to write "smaller" instead of "smalle" in line 75, layers.html
There were the following issues with your Pull Request
Guidelines are available at https://github.com/autumnai/leaf/blob/master/CONTRIBUTING.md#git-commit-guidelines This message was auto-generated by https://gitcop.com |
I was confused docs with doc. Since book/ is in doc/ directory I thought doc is the type. |
Well spotted 😄 The html files are autogenerated (I did the same thing and edited those first). Do you want to fix up the typo here: https://github.com/autumnai/leaf/blob/master/doc/book/layers.html#L75 |
Yes, Sorry if i have misunderstood. I think I have already fixed the typo in this PR. am i missing something here? |
Ah sorry, I meant to link this file: https://github.com/autumnai/leaf/blob/master/doc/src/layers.md My mistake. The html files are generated from the markdown files in there. So you don't want to edit the html directly, because it'll just get overriden next time the docs are built. |
Word "smalle" in line 8 in layers.md should be "smaller"
There were the following issues with your Pull Request
Guidelines are available at https://github.com/autumnai/leaf/blob/master/CONTRIBUTING.md#git-commit-guidelines This message was auto-generated by https://gitcop.com |
Thank you @keshan and @KodrAus. I agree, the thing with the The current setup also leads to issues on Windows machines (#100). |
@keshan Can you squash your two commits into one? That makes the commit history cleaner and resolves the still complaining gitcop issue. You can take the commit message of your second commit. Thank you |
There were the following issues with your Pull Request
Guidelines are available at https://github.com/autumnai/leaf/blob/master/CONTRIBUTING.md#git-commit-guidelines This message was auto-generated by https://gitcop.com |
Whoops. Looks like I fixed the same thing and made the same mistake. Will remove |
Writer should have intended to write "smaller" instead of "smalle" in line 75, layers.html