Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/book: Typo in layers.html #98

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

docs/book: Typo in layers.html #98

wants to merge 3 commits into from

Conversation

keshan
Copy link

@keshan keshan commented Apr 25, 2016

Writer should have intended to write "smaller" instead of "smalle" in line 75, layers.html

Writer should have been intended to write "smaller" instead of "smalle" in line 75, layers.html
@GitCop
Copy link

GitCop commented Apr 25, 2016

There were the following issues with your Pull Request

  • Commit: 1f37e26
    • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/autumnai/leaf/blob/master/CONTRIBUTING.md#git-commit-guidelines


This message was auto-generated by https://gitcop.com

@keshan
Copy link
Author

keshan commented Apr 25, 2016

I was confused docs with doc. Since book/ is in doc/ directory I thought doc is the type.

@KodrAus
Copy link
Contributor

KodrAus commented Apr 25, 2016

Well spotted 😄 The html files are autogenerated (I did the same thing and edited those first).

Do you want to fix up the typo here: https://github.com/autumnai/leaf/blob/master/doc/book/layers.html#L75

@keshan
Copy link
Author

keshan commented Apr 26, 2016

Yes, Sorry if i have misunderstood. I think I have already fixed the typo in this PR. am i missing something here?

@KodrAus
Copy link
Contributor

KodrAus commented Apr 26, 2016

Ah sorry, I meant to link this file: https://github.com/autumnai/leaf/blob/master/doc/src/layers.md

My mistake. The html files are generated from the markdown files in there. So you don't want to edit the html directly, because it'll just get overriden next time the docs are built.

Word "smalle" in line 8 in layers.md should be "smaller"
@GitCop
Copy link

GitCop commented Apr 27, 2016

There were the following issues with your Pull Request

  • Commit: 1f37e26
    • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/autumnai/leaf/blob/master/CONTRIBUTING.md#git-commit-guidelines


This message was auto-generated by https://gitcop.com

@MichaelHirn
Copy link
Member

Thank you @keshan and @KodrAus.

I agree, the thing with the .md and .html version is unnecessarily confusing. I will remove the 'compiled' book and just provide the .md files with a README for how to compile them locally to .html if required.

The current setup also leads to issues on Windows machines (#100).

@MichaelHirn
Copy link
Member

@keshan Can you squash your two commits into one? That makes the commit history cleaner and resolves the still complaining gitcop issue.

You can take the commit message of your second commit. Thank you

@GitCop
Copy link

GitCop commented Apr 28, 2016

There were the following issues with your Pull Request

  • Commit: 1f37e26
    • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/autumnai/leaf/blob/master/CONTRIBUTING.md#git-commit-guidelines


This message was auto-generated by https://gitcop.com

@kav
Copy link

kav commented Nov 17, 2016

Whoops. Looks like I fixed the same thing and made the same mistake. Will remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants