Skip to content

fix: bugprone-error

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Dec 23, 2024 in 59s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.10 (2.68 -> 2.58)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method route_handler.cpp: RouteHandler::getAllRightSharedLinestringLanelets
  • Complex Method route_handler.cpp: RouteHandler::getAllLeftSharedLinestringLanelets

Annotations

Check notice on line 1 in planning/autoware_route_handler/src/route_handler.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 1723 to 1739, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check warning on line 1242 in planning/autoware_route_handler/src/route_handler.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

RouteHandler::getAllRightSharedLinestringLanelets has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1199 in planning/autoware_route_handler/src/route_handler.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

RouteHandler::getAllLeftSharedLinestringLanelets has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in planning/autoware_route_handler/src/route_handler.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 4.82 to 4.86, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.