feat(radar_object_clustering): Created Schema file and updated ReadME file for parameters settings #9966
+89
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vish0012
requested review from
taikitanaka3,
scepter914,
miursh,
technolojin,
YoshiRi,
badai-nguyen and
yukkysaito
as code owners
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
vish0012
changed the title
vish0012
changed the title
Signed-off-by: vish0012 <[email protected]>
vish0012
force-pushed
the
radar_object_clustering
branch
from
b298fd5 to
5887cdd
Compare
github-actions
bot
removed
the
component:vehicle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the autoware_radar_object_clustering
Remove duplication of parameter declaration between the source code and the parameter file.
Remove the default value from the source code to ensure all parameter values are passed from the parameter files.
Use types that match those returned from declare_parameter() to prevent confusion and potential coding errors.
Move the default parameter file to a standardized location. Use the JSON Schema for that.
Related links
Parent Issue:
How was this PR tested?
Successfully build using colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_radar_object_clustering
Passed ros2 launch launch/radar_object_clustering.launch.xml
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.