Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_detection_area): use base class without RTC #9802

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 26, 2024

Description

depends on #9799

behavior_velocity_detection_area_module will be ported to the Autoware.Core.
Therefore, the package has to be independent of tier4_msgs, so I remove the RTC dependency from the package in this PR.

Related links

How was this PR tested?

psim worked well.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 26, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Dec 26, 2024
Copy link

github-actions bot commented Dec 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 changed the title https://tier4.atlassian.net/wiki/spaces/CT/pages/3487275153/P+v4.0.1+Component?focusedCommentId=3487144568 feat(behavior_velocity_detection_area): use base class without RTC Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.78%. Comparing base (4ed851f) to head (8568707).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ior_velocity_detection_area_module/src/manager.cpp 0.00% 4 Missing ⚠️
...avior_velocity_detection_area_module/src/scene.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9802      +/-   ##
==========================================
- Coverage   28.79%   28.78%   -0.01%     
==========================================
  Files        1456     1458       +2     
  Lines      109093   109124      +31     
  Branches    42492    42489       -3     
==========================================
  Hits        31409    31409              
- Misses      74606    74637      +31     
  Partials     3078     3078              
Flag Coverage Δ *Carryforward flag
differential 0.47% <0.00%> (?)
total 28.79% <ø> (+<0.01%) ⬆️ Carriedforward from 4ed851f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 force-pushed the feat/detection-area-without-rtc branch from d3ac28a to 790e5fb Compare December 27, 2024 01:21
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Dec 27, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review December 27, 2024 01:22
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 27, 2024
@takayuki5168 takayuki5168 force-pushed the feat/detection-area-without-rtc branch from 790e5fb to ab61fd6 Compare December 27, 2024 01:51
@kyoichi-sugahara
Copy link
Contributor

please change parameter here

@takayuki5168
Copy link
Contributor Author

@kyoichi-sugahara
Here we have autowarefoundation/autoware_launch#1292

@takayuki5168 takayuki5168 force-pushed the feat/detection-area-without-rtc branch from ab61fd6 to c6b78a7 Compare December 27, 2024 02:04
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
Changed inheritance of DetectionAreaModuleManager class from SceneModuleManagerInterfaceWithRTC to SceneModuleManagerInterface, thus removing the need to update member variables safe_ and distance_, leading to partial modifications in the processing.

Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 merged commit 5de2e4a into autowarefoundation:main Dec 27, 2024
36 checks passed
@takayuki5168 takayuki5168 deleted the feat/detection-area-without-rtc branch December 27, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants