-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_detection_area): use base class without RTC #9802
feat(behavior_velocity_detection_area): use base class without RTC #9802
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9802 +/- ##
==========================================
- Coverage 28.79% 28.78% -0.01%
==========================================
Files 1456 1458 +2
Lines 109093 109124 +31
Branches 42492 42489 -3
==========================================
Hits 31409 31409
- Misses 74606 74637 +31
Partials 3078 3078
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d3ac28a
to
790e5fb
Compare
790e5fb
to
ab61fd6
Compare
please change parameter here |
@kyoichi-sugahara |
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
ab61fd6
to
c6b78a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Changed inheritance of DetectionAreaModuleManager class from SceneModuleManagerInterfaceWithRTC
to SceneModuleManagerInterface
, thus removing the need to update member variables safe_
and distance_
, leading to partial modifications in the processing.
Signed-off-by: Takayuki Murooka <[email protected]>
Description
depends on #9799
behavior_velocity_detection_area_module will be ported to the Autoware.Core.
Therefore, the package has to be independent of tier4_msgs, so I remove the RTC dependency from the package in this PR.
Related links
How was this PR tested?
psim worked well.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.