Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace debug msgs #9797

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

style(pre-commit): autofix

7c4a6e9
Select commit
Loading
Failed to load commit list.
Open

Replace debug msgs #9797

style(pre-commit): autofix
7c4a6e9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Dec 26, 2024 in 1m 7s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.00 (7.58 -> 7.58)

  • Declining Code Health: 3 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method ndt_scan_matcher_core.cpp: NDTScanMatcher::NDTScanMatcher 🔥
  • Complex Method ekf_localizer.cpp: EKFLocalizer::timer_callback
  • Complex Method lane_departure_checker_node.cpp: LaneDepartureCheckerNode::onTimer

Annotations

Check warning on line 366 in control/autoware_lane_departure_checker/src/lane_departure_checker_node/lane_departure_checker_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

LaneDepartureCheckerNode::onTimer already has high cyclomatic complexity, and now it increases in Lines of Code from 86 to 87. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 234 in localization/autoware_ekf_localizer/src/ekf_localizer.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

EKFLocalizer::timer_callback already has high cyclomatic complexity, and now it increases in Lines of Code from 77 to 78. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 188 in localization/autoware_ndt_scan_matcher/src/ndt_scan_matcher_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

NDTScanMatcher::NDTScanMatcher increases from 113 to 116 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.