feat(autoware_traffic_light_arbiter): add current time validation #9747
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: +0.22 (8.55 -> 8.77)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method traffic_light_arbiter.cpp: TrafficLightArbiter::arbitrateAndPublish
✅ Improving Code Health:
- Code Duplication traffic_light_arbiter.cpp
Annotations
Check notice on line 1 in perception/autoware_traffic_light_arbiter/src/traffic_light_arbiter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Code Duplication
The module no longer contains too many functions with similar structure
Check warning on line 246 in perception/autoware_traffic_light_arbiter/src/traffic_light_arbiter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
TrafficLightArbiter::arbitrateAndPublish increases in cyclomatic complexity from 15 to 16, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in perception/autoware_traffic_light_arbiter/src/traffic_light_arbiter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.14 to 4.43, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.