Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): use XXXStamped in autoware_internal_debug_msgs #9744

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 23, 2024

Description

Run the following command, and manually add autoware_internal_debug_msgs in the package.xml

find ./ -type f -exec sed -i -e 's/tier4_debug_msgs\/msg\/string_stamped/autoware_internal_debug_msgs\/msg\/string_stamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs::msg::StringStamped/autoware_internal_debug_msgs::msg::StringStamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs\/msg\/float64_stamped/autoware_internal_debug_msgs\/msg\/float64_stamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs::msg::Float64Stamped/autoware_internal_debug_msgs::msg::Float64Stamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs\/msg\/float32_stamped/autoware_internal_debug_msgs\/msg\/float32_stamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs::msg::Float32Stamped/autoware_internal_debug_msgs::msg::Float32Stamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs\/msg\/int32_stamped/autoware_internal_debug_msgs\/msg\/int32_stamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs::msg::Int32Stamped/autoware_internal_debug_msgs::msg::Int32Stamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs\/msg\/float64_multi_array_stamped/autoware_internal_debug_msgs\/msg\/float64_multi_array_stamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs::msg::Float64MultiArrayStamped/autoware_internal_debug_msgs::msg::Float64MultiArrayStamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs\/msg\/float32_multi_array_stamped/autoware_internal_debug_msgs\/msg\/float32_multi_array_stamped/g' {} \;
find ./ -type f -exec sed -i -e 's/tier4_debug_msgs::msg::Float32MultiArrayStamped/autoware_internal_debug_msgs::msg::Float32MultiArrayStamped/g' {} \;

Related links

autowarefoundation/autoware#5580

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 force-pushed the feat/use-string-stamped-in-autoware-internal-msgs-behavior-planning branch from f9a0ec4 to 5d20536 Compare December 23, 2024 14:42
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 23, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review December 24, 2024 00:02
@takayuki5168 takayuki5168 marked this pull request as draft December 24, 2024 01:05
@takayuki5168 takayuki5168 force-pushed the feat/use-string-stamped-in-autoware-internal-msgs-behavior-planning branch from 805577c to 952758e Compare December 24, 2024 01:33
@takayuki5168 takayuki5168 changed the title feat(behavior planning): use StringStamped in autoware_internal_debug_msgs feat(behavior_velocity_planner): use StringStamped in autoware_internal_debug_msgs Dec 24, 2024
@takayuki5168 takayuki5168 changed the title feat(behavior_velocity_planner): use StringStamped in autoware_internal_debug_msgs feat(behavior_velocity_planner): use XXXStamped in autoware_internal_debug_msgs Dec 24, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review December 25, 2024 04:58
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the feat/use-string-stamped-in-autoware-internal-msgs-behavior-planning branch from 1546d85 to 97b2efb Compare December 25, 2024 04:59
@takayuki5168
Copy link
Contributor Author

@yuki-takagi-66 @maxime-clem
FYI:
For the maintainers of the crosswalk and run_out modules, I will merge this PR once the CI passes.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.66%. Comparing base (3d53032) to head (97b2efb).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 3 Missing ⚠️
...ity_intersection_module/src/scene_intersection.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9744   +/-   ##
=======================================
  Coverage   29.66%   29.66%           
=======================================
  Files        1450     1455    +5     
  Lines      108833   108884   +51     
  Branches    42740    42742    +2     
=======================================
+ Hits        32285    32305   +20     
- Misses      73375    73408   +33     
+ Partials     3173     3171    -2     
Flag Coverage Δ *Carryforward flag
differential 24.15% <0.00%> (?)
total 29.68% <ø> (+0.01%) ⬆️ Carriedforward from 16d5cb1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 2579f3c into autowarefoundation:main Dec 25, 2024
36 checks passed
@takayuki5168 takayuki5168 deleted the feat/use-string-stamped-in-autoware-internal-msgs-behavior-planning branch December 25, 2024 06:58
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 27, 2024
…debug_msgs (autowarefoundation#9744)

* feat(behavior_velocity_planner): use XXXStamped in autoware_internal_debug_msgs

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants